Add semantic section elements #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, the unit tests complain that |
|
I have reported the validator bug here: validator/validator#1104 |
selfthinker
force-pushed
the
semantic-section-elements
branch
from
ee124d5
to
02f76b9
Compare
|
Well, |
selfthinker
force-pushed
the
semantic-section-elements
branch
from
02f76b9
to
a1e4564
Compare
This changes the divs for the main content, header, footer, sidebar and page tools to their semantic equivalent (main, header, footer, nav and nav again) and adds ARIA labels where appropriate. The media manager popup changes to have a main and a nav.
selfthinker
force-pushed
the
semantic-section-elements
branch
from
a1e4564
to
834b0b2
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the divs for the main content, header, footer, sidebar and page tools to their semantic equivalent (main, header, footer, nav and nav again) and adds ARIA labels.
The media manager popup changes to have a main and a nav.
This also changes the divs around user tools, site tools and breadcrumbs to navs.Because it is best practice to not have too many navigation landmarks but only the most important ones for screen reader users, this intentionally removes these
navs' semantics again viarole=presentation. Those are relatively easy to get to anyway as they are all in the header.That makes it sort of unnecessary to add the
navs in the first place, but I thought it's more consistent that way. (I'd also be happy to remove the second commit which does that.)When using the Landmarks browser extension, the landmarks will become visible.
One question: I made the sidebar have a
nav, but we cannot be sure if it is used as a navigation. If it is not used as one, anasidewould be more appropriate. In the Starter template I solved this by making it configurable.But I suspect you'd probably not want another config option in the core?
It would be good if we had more data on how the sidebar is used to make a better informed decision.