Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move IXR XML RPC to composer dependency #1970 #3534

Merged
merged 1 commit into from Nov 11, 2021
Merged

move IXR XML RPC to composer dependency #1970 #3534

merged 1 commit into from Nov 11, 2021

Conversation

splitbrain
Copy link
Collaborator

This is a monky patched version of kissyfrot/php-ixr until my PR has
been accepted upstream.

Plugins using the XML RPC client may need adjustments.

This is a monky patched version of kissyfrot/php-ixr until my PR has
been accepted upstream.

Plugins using the XML RPC client may need adjustments.
@turnermm
Copy link
Contributor

Plugins using the XML RPC client may need adjustments.

What kind of adjustments?

@splitbrain
Copy link
Collaborator Author

The client is now namespaced \dokuwiki\Remote\IXR\Client and no longer inherits from HTTPClient but from the original IXR Client.

@turnermm
Copy link
Contributor

It's no longer possible to set the debug parameter, as shown in the demos:
https://www.dokuwiki.org/devel:xmlrpc:clients
It throws one of two errors, depending on whether you use the setDebug method or set the property directly using $client->debug.

Error: Call to undefined method dokuwiki\Remote\IXR\Client::setDebug()
Error: Cannot access protected property dokuwiki\Remote\IXR\Client::$debug

It turns out that the debug value was a function of HTTPClient.

@splitbrain
Copy link
Collaborator Author

docs will need to be adjusted. you can call getHttpClient() and set debugging on that

@turnermm
Copy link
Contributor

Thanks. Works perfectly. I'll update the docs.

@turnermm
Copy link
Contributor

But I'll wait until the new code is merged.

@splitbrain splitbrain merged commit 0691b3f into master Nov 11, 2021
@splitbrain splitbrain deleted the ixr branch November 11, 2021 12:43
@Klap-in
Copy link
Collaborator

Klap-in commented Dec 23, 2021

@turnermm Do you have the opportunity to update the docs? If you are done, could you remove the label please?

@turnermm
Copy link
Contributor

turnermm commented Dec 24, 2021

Docs have been updated
https://www.dokuwiki.org/devel:xmlrpc:clients#sample_php_client

I can't remove label. I guess splitbrain has to do that since he added the label.

@turnermm
Copy link
Contributor

Ah, I see you not splitbrain added the tlo-do label

@Klap-in
Copy link
Collaborator

Klap-in commented Dec 24, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants