Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3619 and correctly handle exceptions in XMLRPC #3620

Merged
merged 2 commits into from Feb 6, 2022
Merged

Conversation

splitbrain
Copy link
Collaborator

This ensures that any exception happening during XMLRPC processing is
signalled correctly to the client as XML encoded error message.

This ensures that any exception happening during XMLRPC processing is
signalled correctly to the client as XML encoded error message.
@Klap-in
Copy link
Collaborator

Klap-in commented Feb 4, 2022

@satwareAG-ironMike and @rozhuk-im could you review/test this?

@rozhuk-im
Copy link

2022-02-04 22:26:37	/usr/local/www/wiki/inc/Remote/XmlRpcServer.php(24)	IXR\Exception\ServerException: XML-RPC server not enabled.
  #0 /usr/local/www/wiki/lib/exe/xmlrpc.php(13): dokuwiki\Remote\XmlRpcServer->__construct()
  #1 {main}

in log, but dokuwiki android client got

XmlRpc call wiki.getPageHTML error: org.apache.xmlrpc.client.XmlRpcClientException: Failed to parse server's response: Expected methodResponse element, got html

I expect that client will receive: "XML-RPC server not enabled." error message and do not get error messages in log.

@splitbrain
Copy link
Collaborator Author

@rozhuk-im did you actually use the correct branch?

@rozhuk-im
Copy link

4ef5d38 + 4b86732

@splitbrain
Copy link
Collaborator Author

Ah you're right. I aborted too early... should work now.

@rozhuk-im
Copy link

Now client receive: XmlRpc call dokuwiki.getTitle error: org.apache.xmlrpc.XmlRpcException: XML-RPC server not enabled.
and I see no errors in log.
Looks like fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants