Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Popularity plugin intro text #3944

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

dregad
Copy link
Contributor

@dregad dregad commented Apr 5, 2023

No description provided.

@dregad
Copy link
Contributor Author

dregad commented Apr 5, 2023

I think something's wrong with the unit test's design - no way this change could introduce such failure.

1) remoteapicore_test::test_coreattachments
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    'lastModified' => 1680711453
+    'lastModified' => 1680711454
     'size' => 0
 )

@fiwswe
Copy link
Collaborator

fiwswe commented Apr 5, 2023

I think something's wrong with the unit test's design - no way this change could introduce such failure.

1) remoteapicore_test::test_coreattachments
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    'lastModified' => 1680711453
+    'lastModified' => 1680711454
     'size' => 0
 )

These sort of off-by-one-second timing issues seem to crop up often on GitHub. See #3781 for example. They can be safely ignored as they are artefacts of the testing code, not errors in the tested code.

@dregad
Copy link
Contributor Author

dregad commented Apr 6, 2023

they are artefacts of the testing code, not errors in the tested code.

That was my point exactly. Thanks for linking #3781.

@splitbrain splitbrain merged commit efc6165 into dokuwiki:master Apr 26, 2023
9 of 13 checks passed
@dregad dregad deleted the patch-1 branch April 27, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants