Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8 deprecated warnings #3947

Merged
merged 3 commits into from Apr 26, 2023
Merged

Conversation

dregad
Copy link
Contributor

@dregad dregad commented Apr 6, 2023

See commit messages for details

Adding null-coalescing operator to avoid

str_replace(): Passing null to parameter dokuwiki#3 ($subject) of type
array|string is deprecated
Fixes Creation of dynamic property _HWLDF_WordAccumulator::$_lines /
$_line / $_group / $_tag is deprecated in ./inc/DifferenceEngine.php
on line 936

And proactively caught another bunch in _Diff3_Op class (not reported
in unit tests)
@splitbrain splitbrain merged commit 565c020 into dokuwiki:master Apr 26, 2023
11 of 13 checks passed
@dregad dregad deleted the php8_deprecated branch April 27, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants