Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in comments or code style #3959

Closed
wants to merge 7 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Apr 25, 2023

Continue #3942

Fixes some issues that I or IDE made while surfing the code.

Copy link
Collaborator

@splitbrain splitbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far. Since this is still marked as draft, are you still working on it?

inc/HTTP/HTTPClient.php Outdated Show resolved Hide resolved
@glensc glensc marked this pull request as ready for review April 28, 2023 16:32
@glensc
Copy link
Contributor Author

glensc commented Apr 28, 2023

Removed Draft. I guess this can be merged since you already reviewed the changes.

@glensc
Copy link
Contributor Author

glensc commented Aug 3, 2023

Rebased against c6ca82d

@splitbrain
Copy link
Collaborator

I think most of this has been obsoleted by running rector on the code base. Do you want to rebase it or shall we close it?

@splitbrain splitbrain closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants