Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip any trailing dots when resolving IDs #4074

Merged
merged 3 commits into from Oct 12, 2023
Merged

strip any trailing dots when resolving IDs #4074

merged 3 commits into from Oct 12, 2023

Conversation

splitbrain
Copy link
Collaborator

fixes #4072

These tests have been moved to the File namespace.
Copy link
Collaborator

@Klap-in Klap-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me.
Probably using rtrim() is more precise what is meant?

inc/File/Resolver.php Outdated Show resolved Hide resolved
@splitbrain splitbrain merged commit 2f624be into master Oct 12, 2023
12 checks passed
@splitbrain splitbrain deleted the issue4072 branch October 12, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:.. resolved with warning
2 participants