add TEMPLATE_SITETOOLS_DISPLAY and TEMPLATE_USERTOOLS_DISPLAY basing on ... #470
Conversation
…on Starter template
| 'profile' => tpl_action('profile', 1, 'li', 1), | ||
| 'register' => tpl_action('register', 1, 'li', 1), | ||
| 'login' => tpl_action('login', 1, 'li', 1), | ||
| )); |
|
Both events only really make sense in the dokuwiki template. Other templates may have structured actions differently. They might also use different markup (buttons vs. links, list items or not). The events get raw HTML passed here which isn't terrible useful. |
|
I wonder if we need to allow templates to supply or override the wrapping markup for action links, buttons and toolbars. |
|
TEMPLATE_SITETOOLS_DISPLAY and TEMPLATE_USERTOOLS_DISPLAY are already in the starter template, so these events are triggered more often... |
|
So what is the status of my request. Do you want to have TEMPLATE_SITETOOLS_DISPLAY and TEMPLATE_USERTOOLS_DISPLAY in dokuwiki template? Maybe you have same proposals how to rebuild the patch to fit your needs? |
|
We didn't get to this PR during last Sunday's IRC meeting. Hopefully we'll get to it at the next one. |
|
Why I cannot find this changes/commit in the master branch anymore? It seems to be merged looking in this thread, but in code it is invisible... |
|
Hmmm, I think I have spotted the issue. This was mixed with PR 1046, but is reverted. |
|
I think what happened is that @Hafron made the changes for this PR on his master branch (which is never a good idea, always use feature branches) and then created the html_showrev_output branch for #1046 from his master branch. Then he realised something was in there which shouldn't be (as this PR wasn't merged yet and his master branch wasn't up-to-date) and reverted it. But reverting in any branch which gets merged means reverting in master as well when this got merged. |
…ruct-column-in-bureaucracy-form Fix FatalError on unknown struct column in bureaucracy forms
I've add TEMPLATE_SITETOOLS_DISPLAY and TEMPLATE_USERTOOLS_DISPLAY events do main dokuwiki template basing on code from Starter template. I think that it can be useful.