Event handler improvements (cont.) #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to sort on add from sort on process for efficiency. Some events (e.g. AUTH_ACL_CHECK) could be trigged many times in a single page request.
splitbrain
added a commit
that referenced
this pull request
Feb 16, 2014
Event handler improvements (cont.)
|
@michitux - did you get a look at this (it includes changing hook sorting to hook add)? |
|
Yes, I've looked at the code. Your solution for the sorting is great as for most events it won't sort anything. I think I've seen at least one plugin that accesses _hooks in order to add itself as first call (though I don't remember which) so this will probably break plugins. I think this is okay as plugins were never supposed to access it, but we should at least mention it in the changes. |
|
sorr, in what version is this in? |
|
Its not in any released version (yet). It will be in the next release. Its currently available from github master branch. |
glensc
added a commit
to glensc/dokuwiki-plugin-pageredirect
that referenced
this pull request
Apr 14, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap sorting of hook array from event processing to trigger registration for efficiency.
Plus more PHP 5 updates.