Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor detail.php to template.php #573

Merged
merged 2 commits into from Mar 16, 2014
Merged

Conversation

Klap-in
Copy link
Collaborator

@Klap-in Klap-in commented Feb 25, 2014

https://bugs.dokuwiki.org/index.php?do=details&task_id=2437

done:

  • refactor back and mediamanager link creation
  • refactor metadata listing

Note: added placeholder replacement in action captions

Question:

  • Should the IPTC.Headline and the simple.title should also be coming from a function of their own? (as suggested by issue?) If yes, how?

todo:

  • fix other translations

- refactor detail en mediamanager link creation
- refactor metadata listing
@splitbrain
Copy link
Collaborator

@selfthinker any comments on this?

@selfthinker
Copy link
Collaborator

No comment. I'm happy that it got done. But as it's a backendy task, there is not much I can say. All seems fine.

@splitbrain
Copy link
Collaborator

Seems to be okay 👍

@Chris--S
Copy link
Collaborator

👍

splitbrain added a commit that referenced this pull request Mar 16, 2014
@splitbrain splitbrain merged commit e9ac087 into master Mar 16, 2014
@splitbrain splitbrain deleted the FS#2437detailphprefactor branch March 16, 2014 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants