define overridable constants for session properties FS#1913 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(!defined('DOKU_SESSION_DOMAIN')) define ('DOKU_SESSION_DOMAIN', ''); | ||
|
|
||
| session_name(DOKU_SESSION_NAME); | ||
| if(version_compare(PHP_VERSION, '5.2.0', '>')) { |
There was a problem hiding this comment.
do we still need this version check? min. dokuwiki requirement is 5.2
There was a problem hiding this comment.
PHP api writes:
5.2.0 The httponly parameter was added.
(i guess the check had must be >= instead of >, hasn't?)
So I think that removing this check is ok.
There was a problem hiding this comment.
yeah this can be removed
|
👍 except from version check |
|
FYI, the version check code is also in inc/auth.php in auth_logoff() around line 500. |
- moved cookiedir determination in the if-statement
Chris--S
added a commit
that referenced
this pull request
Mar 5, 2014
define overridable constants for session properties FS#1913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.dokuwiki.org/index.php?do=details&task_id=1913