Allow arbitrary mediatype names for CSS #982
Conversation
They are generated from the default ones and any additional one given by the template. This allows to e.g. split admin styles from end user styles in a closed wiki. You can then deliver only the user styles using the metaheaders plugin.
|
The inspection completed: No new issues |
|
👍 |
Allow arbitrary mediatype names for CSS
|
Since this has been merged, all the templates with old style RTL styles are buggy now as basically anything is accepted as a media type now. We should only allow valid media types. |
|
I created #1131 for this. Another thing I found (which I also mention in #1131): So, even without that bug, these changes are effectively not working. No new media types are added to the resulting css file. |
|
This pull request should have had no influence as described in #1131. However, it is ineffective without #1002 which introduces the media type handling (and #1003 which allows multiple media types for the same style file). It also introduces an event for JS modifications and respective caching which should also allow caching for different templates as #1130 intends (maybe not as effective?!) Anyway, the situation seems a bit complicated to me. How can we proceed? I wonder: do no unit tests exist to ensure compatibility (maybe I should have attached some with this pull request...) |
|
If this is ineffective without #1002, shouldn't these changes be part of that PR instead? |
This reverts commit de4634e.
|
This has been reverted as discussed in #1131 |
This adds the ability to the css.php to deliver arbitrary media types that have to be defined in the styles.ini file. The template can now decide to have a style that is only delivered to admins for example.