Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbering start from number doesn't work fix #1057

Conversation

anti-the-social
Copy link
Contributor

Use level.start for overrideLevel.start if possible.
Implemented via additional reference config map.

Implemented via additional reference config map.
@dolanmiu
Copy link
Owner

Could you have a look at the broken tests? @anti-the-social

@codecov-commenter
Copy link

Codecov Report

Merging #1057 (f378c37) into master (75587df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         311      311           
  Lines        3548     3557    +9     
  Branches      444      379   -65     
=======================================
+ Hits         3523     3532    +9     
  Misses         24       24           
  Partials        1        1           
Impacted Files Coverage Δ
src/file/numbering/numbering.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75587df...f378c37. Read the comment docs.

@dolanmiu
Copy link
Owner

dolanmiu commented Aug 1, 2021

@anti-the-social
Copy link
Contributor Author

@dolanmiu just checked: result for demo number 3 at the master branch and "Numbering-start-from-number-doesn't-work" branch are identical
image
image

@dolanmiu
Copy link
Owner

dolanmiu commented Aug 1, 2021

Perfect, merging

@dolanmiu dolanmiu merged commit 1401327 into dolanmiu:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants