Change type of revision to a number #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just worked through a bug that I didn't realize that
revision
in document properties had to be a number. I have changed the TypeScript to only allow numbers, which I think is clearer. This made the word doc angry when it was opened if there is arbitrary string in there.The code change is backwards compatible as we cast this to a string before writing to XML. However, this will require people to unquote their revision numbers if they are using typescript.