Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed "both" as a verticalAlign feature #1562

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

GiladFeder
Copy link
Contributor

@GiladFeder GiladFeder commented Jun 24, 2022

fixes: #1514

Hey! Hope this is a good PR. Would love to contribute more.

@codecov-commenter
Copy link

Codecov Report

Merging #1562 (60096a9) into master (49054da) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
- Coverage   99.42%   99.42%   -0.01%     
==========================================
  Files         316      316              
  Lines        3639     3638       -1     
  Branches      395      395              
==========================================
- Hits         3618     3617       -1     
  Misses         20       20              
  Partials        1        1              
Impacted Files Coverage Δ
src/file/vertical-align/vertical-align.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49054da...60096a9. Read the comment docs.

@dolanmiu dolanmiu merged commit c19bc6b into dolanmiu:master Jun 25, 2022
@dolanmiu
Copy link
Owner

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell vertical align prop is more explicit, than it should be
3 participants