Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override levels impl #1823

Merged
merged 19 commits into from Dec 10, 2022
Merged

Conversation

anti-the-social
Copy link
Contributor

Bonjour :)

Finally got some time to take care of this.
Tell me the secret of running tests! :) Just after polling and npm i you cannot really run npm test
I am getting TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for

Nevertheless I believe it should work.
I also fixed and added additional tests to this breaking change improvements.

This pull request is related to this issue: #1740

@dolanmiu
Copy link
Owner

dolanmiu commented Dec 7, 2022

Wow, very nice

Will review

Regarding the tests, I believe it's because of nanoid, if that is downgraded, then tests should work I think

@anti-the-social
Copy link
Contributor Author

Nanoid has critical vulnerability in the older versions, than 4.
I also have doubts that its the reason (just tried npm i nanoid 3 npm test)

@dolanmiu
Copy link
Owner

Nanoid has critical vulnerability in the older versions, than 4. I also have doubts that its the reason (just tried npm i nanoid 3 npm test)

No it must be, because there is an open PR which only upgrades nanoid from 3 -> 4, and it broke:

#1548

Take a look

@dolanmiu
Copy link
Owner

There is one broken test in the project

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Base: 99.82% // Head: 99.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8509bcc) compared to base (3ea453a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1823   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         317      317           
  Lines        3894     3896    +2     
  Branches      476      476           
=======================================
+ Hits         3887     3889    +2     
  Misses          7        7           
Impacted Files Coverage Δ
src/file/numbering/numbering.ts 100.00% <ø> (ø)
src/file/numbering/num.ts 100.00% <100.00%> (ø)
src/file/document/document.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anti-the-social
Copy link
Contributor Author

Fixed failing test - my bad.

And also found after local testing that some tests at src/file/paragraph/run/comment-run.spec.ts were failing for me - reason seems to be the timezone. So I've fixed it via specifying full date in new Date() creation.

Now its all good for me too
image

@dolanmiu dolanmiu merged commit c8914a1 into dolanmiu:master Dec 10, 2022
@dolanmiu
Copy link
Owner

Amazing, merged

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants