Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#940 - Add positional tab feature #1852

Merged
merged 3 commits into from Dec 24, 2022
Merged

#940 - Add positional tab feature #1852

merged 3 commits into from Dec 24, 2022

Conversation

dolanmiu
Copy link
Owner

Also add extra run elements as per spec

Also add extra run elements as per spec
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 99.82% // Head: 99.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (473ad29) compared to base (49b4ca6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1852   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files         318      319    +1     
  Lines        3912     3980   +68     
  Branches      550      553    +3     
=======================================
+ Hits         3905     3973   +68     
  Misses          7        7           
Impacted Files Coverage Δ
src/file/paragraph/run/run.ts 100.00% <ø> (ø)
src/file/paragraph/run/empty-children.ts 100.00% <100.00%> (ø)
src/file/paragraph/run/index.ts 100.00% <100.00%> (ø)
src/file/paragraph/run/positional-tab.ts 100.00% <100.00%> (ø)
src/file/xml-components/simple-elements.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dolanmiu dolanmiu merged commit 9bfb5bf into master Dec 24, 2022
@dolanmiu dolanmiu deleted the feat/positional-tab branch December 24, 2022 21:02
@ulion
Copy link

ulion commented Feb 1, 2023

@dolanmiu This is wonderful, will a new version be released soon?

@dolanmiu
Copy link
Owner Author

dolanmiu commented Feb 1, 2023

Will be soon yes, just want some other features in first before releasing. Next version will be a major

@ulion
Copy link

ulion commented Feb 2, 2023

cool~ look forward to it.

@ulion
Copy link

ulion commented Feb 2, 2023

ops, this was already in 7.8.2, thanks for the feature~~

@ulion
Copy link

ulion commented Feb 2, 2023

oh, it's not... :(

@KhanhHH
Copy link

KhanhHH commented Mar 13, 2023

when? 😭😭😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants