Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bullet list creating #68

Merged
merged 6 commits into from
Apr 10, 2018
Merged

Updated bullet list creating #68

merged 6 commits into from
Apr 10, 2018

Conversation

ilmartyrk
Copy link
Contributor

Changed bullet list items with unicode characters to look like MS Words default bulletpoints. Also added indendt levelt to bullet list. Also fixed some demo files.

@dolanmiu
Copy link
Owner

Thanks so much!

Could you make the build and tests pass, then ill merge

@dolanmiu
Copy link
Owner

Could you revert your changes in demo10.js? I like trailing commas

@ilmartyrk
Copy link
Contributor Author

Reverted demo10.js and fixed paragraph tests. I actually removed trailing comas because in my build demo10 failed because of these. I currently use node 6.13.1. Just for your information

@dolanmiu
Copy link
Owner

dolanmiu commented Apr 10, 2018

What the difference between --debug-check and --list-different?

Another useful flag is --list-different (or -l) which prints the filenames of files that are different from Prettier formatting. If there are differences the script errors out, which is useful in a CI scenario.

I see you made a commit to change -l to --debug-check, which made the tests pass but maybe doesn't solve the underlying problem

I will have a look tonight if you are having trouble

@ilmartyrk
Copy link
Contributor Author

ilmartyrk commented Apr 10, 2018

I couldn't get my head around that. npm run style always failed in files src/file/numbering/numbering.ts And only information is
npm ERR! Linux 4.4.0-119-generic npm ERR! argv "/home/ilmar/.nvm/versions/node/v6.13.1/bin/node" "/home/ilmar/.nvm/versions/node/v6.13.1/bin/npm" "run" "style" npm ERR! node v6.13.1 npm ERR! npm v3.10.10 npm ERR! code ELIFECYCLE npm ERR! docx@3.3.0 style: prettier -l "src//*.ts"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the docx@3.3.0 style script 'prettier -l "src/
/.ts"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the docx package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! prettier -l "src/**/
.ts"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs docx
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls docx
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /home/ilmar/cosdocx/docx/npm-debug.log`

It also failed when I reverted that file to your original version

@dolanmiu dolanmiu merged commit 02f80bc into dolanmiu:master Apr 10, 2018
@dolanmiu
Copy link
Owner

I will merge this and fix it later, I know what is the issue

Prettier manages all the formatting, and it had other ideas of it's own, I will show you after

@dolanmiu
Copy link
Owner

dolanmiu commented Apr 10, 2018

https://github.com/dolanmiu/docx/blob/master/src/file/numbering/numbering.ts

Its differently formatted to be Prettier compliant

Thanks again! I will release a new version today with this change in

@dolanmiu
Copy link
Owner

Released in 3.4.0

@ilmartyrk
Copy link
Contributor Author

Thank you for the explanation I was too much in a hurry to actually look what the problem was. Sorry for all the extra trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants