Fix footer import #854
Merged
Fix footer import #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Will merge once CI passes |
|
How long does it normally take for codecov/patch & codecov/project to pass 🤔 ? PR has been open 4 days, we'd love this PR in too :-) |
Maybe it can't run off a fork branch or somthing? 🤷 |
|
Merged in Pretty sure there was a bug in the CI, doubt anything should take literal days 😄 Will cut a release tomorrow |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the footer import consistent with the header import, and fixes the compilation issue described in #843. Seems like a trivial fix, but I would appreciate a release for this as it's blocking me upgrading to docx v6.