VOYAG-11116 moving components into sharable packages #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
…r to the libs folder
# Conflicts: # README.md
turbidwater
requested review from
gsimplicio-emed,
dubeyShivank,
ngietka and
gregdolby
ngietka
approved these changes
Sep 14, 2023
gsimplicio-emed
approved these changes
Sep 17, 2023
|
|
||
| export const NoStream = () => { | ||
| const NoStream = () => { |
There was a problem hiding this comment.
curiosity: why did remove the named export?
There was a problem hiding this comment.
I was following the style of some of the components in the libs folder that instead did the default export at the bottom. I wasn't sure if there was a particular reason, but I was trying to match the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the components into libs dir for sharing. Replaces previous PR because it has signed commits.