Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access var in LeagueItemDto #42

Closed
maxiz22 opened this issue Jan 14, 2019 · 1 comment
Closed

Access var in LeagueItemDto #42

maxiz22 opened this issue Jan 14, 2019 · 1 comment
Assignees
Labels
enhancement A good idea for new feature.

Comments

@maxiz22
Copy link

maxiz22 commented Jan 14, 2019

Describe the bug
Access var in LeagueItemDto class. Please change $summonerId and $summonerName to public
in RiotAPI.

namespace RiotAPI\LeagueAPI\Objects;
class LeagueItemDto extends ApiObject {
    /** @var string $summonerId */
    public $summonerId;

    /** @var string $summonerName */
    public $summonerName;
}

I offer myself as a contributor for this proyect , it's genial
Regards!

@dolejska-daniel dolejska-daniel self-assigned this Jan 14, 2019
@dolejska-daniel dolejska-daniel added the enhancement A good idea for new feature. label Jan 14, 2019
@dolejska-daniel
Copy link
Owner

dolejska-daniel commented Jan 14, 2019

Hello and thanks for the report @maxiz22!
The object properties are not yet in the official API docs, so it wasn't updated as it should have been when I processed the documentation so I added them manually 😸.

Also huge thanks for the thumbs up ❤️! I'm pleased you like the library 😺.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A good idea for new feature.
Projects
None yet
Development

No branches or pull requests

2 participants