Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limit #47

Closed
paranic opened this issue Mar 27, 2019 · 2 comments
Closed

Rate Limit #47

paranic opened this issue Mar 27, 2019 · 2 comments
Assignees
@dolejska-daniel

Comments

@paranic
Copy link

paranic commented Mar 27, 2019

Description
Rate limit is not honored.

To Reproduce
Steps to reproduce the behavior:

  1. set LeagueAPI::SET_CACHE_RATELIMIT => true as instructed by wiki
  2. make some request
  3. got some ServerLimitException with message "API call rate limit would be exceeded by this call."
  4. then got some ServerLimitException with message "LeagueAPI: Rate limit for this API key was exceeded."

Expected behavior
who knows? maybe set limit exceed action.
@dolejska-daniel dolejska-daniel self-assigned this Aug 24, 2019
@dolejska-daniel
Copy link
Owner

Hello @paranic, I've tested this myself, and what you are describing did not happen. Are you sure you are using latest version of this library? Please, if you have any more insights, feel free to comment.

@dolejska-daniel
Copy link
Owner

I'm closing this issue, since there has been no update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dolejska-daniel dolejska-daniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paranic @dolejska-daniel