-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.1.0] Conflict with projects using Symfony 4 #58
Comments
Hello, I thought this could be a problem for some people... Update of In that situation this library becomes unusable for people using PHP7.0. |
I can definitely understand that point of view. I'll stay 3.0.11 for now and fork it if there's any API changes. Hopefully a symfony 4 version bump will be more appropriate in the future. Thanks for creating and maintaining an otherwise great lib :) |
@dolejska-daniel, I'm starting a new project using Symfony 4, and I got this issue. I had to install v3.0.11, but I'm wondering how much of an issue will it become for futur Riot API updates? I think that if you want to still support PHP 7.0, you will need to maintain two branches? |
Hi @hawezo I currently do have two options:
I guess I can try to support two branches for now having the PHP7.0 branch only to receive necessary API updates and fixes without receiving possible latest library features. |
I think supporting the two versions if the best option, but it obviously comes with more work. You can define an end-of-support date, though, so you don't have to endlessly take care of the PHP 7.0 branch and eventually drop it. Whatever option you chose, thanks for your work :) |
Alright guys, @techiigg, @hawezo - you can now use The PHP7.0 version of the library is now available through the |
Thanks a lot! |
Bug description
Laravel has required symfony 4.0 or greater since tag 5.6 (Laravel/Framework 5.6, 5.7, 5.8 and 6.0). They swapped in December 2017
(laravel/framework@eadcabe)
All versions after 3.0.11 will therefore be denied on require or hang (in my case, for a really long time) on composer update.
To Reproduce
composer require dolejska-daniel/riot-api
Expected behavior
riot-api should be installed.
Might be as simple as a version bump, but I'm not sure how complex an update from symfony/console v3 => v4 will be.
The text was updated successfully, but these errors were encountered: