Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bicep and CI workflow #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add bicep and CI workflow #3

wants to merge 2 commits into from

Conversation

jbpaux
Copy link

@jbpaux jbpaux commented Jun 16, 2022

Hi,
I love your workbook.
In order to simplify the evolution of your workbook I suggest the following:

  • Add Bicep template as Bicep is great 馃槄
  • Leverage Bicep capability to dynamically inject external files when building the JSON ARM Template so you can use your existing workbook file and only update it without having to worry about the corresponding ARM Template
  • Add CI to dynamically generate the ARM Template when either the bicep or or the workbook change

Since the Bicep Azure Action is not compatible with spaces in the file names I took the liberty of removing them (and I did a PR to the action to handle that in the future)

@jbpaux
Copy link
Author

jbpaux commented Jun 23, 2022

if you can have a look @dolevshor 馃槈

@yaya2devops
Copy link

That's great! @jbpaux

@dolevshor
Copy link
Owner

Hi @jbpaux,
First, thank a lot for your PR and my apologies for responding only now.
I would love to add your 'bicep and CI workflow' part, I can't merge it now because number of changes.
I will make sure to include it in the next version that will be updated soon.

@jbpaux
Copy link
Author

jbpaux commented Jan 9, 2023

Hi,
I've rebased to include your latest changes. It should be good to merge now !

Add quotes to file names

update bicep action to latest

Bump checkout GH Action version
@jbpaux
Copy link
Author

jbpaux commented Mar 27, 2023

@dolevshor I have re-rebased to include your latest changes. Feel free to merge it when you want

@LuisFinOps
Copy link

Hi @dolevshor,
Your Workbook is very useful, so great job!!!.
I麓m just new overhere, so looking into your workbook, I figure out as an idea, if is it possible to include the following below new properties to these dashboards with the aim to give more cost visibility and provide value from FinOps management perspective.

Therefore, I麓ve saw within this MS AZ public workbook "Azure | Home | Advisor | Workbooks | Gallery Cost | Optimization (Preview)" that it is possible to customize it, so looking into "advisorresources" tables under the following path "HOME>AZURE RESOURCE GRAPH EXPLORER>TABLE>advisorresources" url: "https://learn.microsoft.com/en-us/azure/cost-management-billing/finops/cost-optimization-workbook"), I麓ve found these properties that I think will be useful to include it just to provide more inventory tracking and cost granularity view, to show to each Engineering Team what are the Acumulated Costs Impact of each idle resources and takes asap responsability on its optimizations.

I麓m not a AZ technical expert, just a FinOps practitioner, so these are the following properties that I beleive from my point of view could be nice to include it on your Workbook:

Tables:

  • microsoft.advisor/assessments >systemData > "lastModifiedByType" + "lastModifiedAt" + "createdAt"
  • microsoft.advisor/recomendations > extendedProperties > "annualSavingsAmount" + "savingsAmount" + "percentSavings" + "environment" + "resourceMonthlyCost"

Fyi, I麓m not a native english speaker, so apologize for any grammatical mistake and I hopes that this provide more value to this workbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants