Merge pull request #269 from dolittle/fix-validation-middleware-bug

Fix validation middleware bug
dolittle · Feb 22, 2022 · ef8e381 · ef8e381
2 parents 26aba9e + 051c44f
commit ef8e381
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -54,6 +54,24 @@ jobs:
           version: ${{ steps.context.outputs.current-version }}
           release-type: ${{ steps.context.outputs.release-type }}
 
+      - name: Remove any existing artifacts
+        run: rm -rf ${{ env.NUGET_OUTPUT }}
+
+      - name: Create NuGet packages
+        if: ${{ steps.context.outputs.should-publish == 'true' }}
+        run: dotnet pack --no-build --configuration Release -o ${{ env.NUGET_OUTPUT }} -p:PackageVersion=${{ steps.increment-version.outputs.next-version }} -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
+
+      - name: Push NuGet packages
+        if: ${{ steps.context.outputs.should-publish == 'true' }}
+        run: dotnet nuget push --skip-duplicate '${{ env.NUGET_OUTPUT }}/*.nupkg' --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
+
+      - name: Publish NPM packages
+        if: ${{ steps.context.outputs.should-publish == 'true' }}
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+        run: |
+          yarn publish-version ${{ steps.increment-version.outputs.next-version }}
+
       - name: Prepend to Changelog
         if: ${{ steps.context.outputs.should-publish == 'true' }}
         uses: dolittle/add-to-changelog-action@v2
@@ -73,24 +91,6 @@ jobs:
           version: ${{ steps.increment-version.outputs.next-version }}
           body: ${{ steps.context.outputs.pr-body }}
 
-      - name: Remove any existing artifacts
-        run: rm -rf ${{ env.NUGET_OUTPUT }}
-
-      - name: Create NuGet packages
-        if: ${{ steps.context.outputs.should-publish == 'true' }}
-        run: dotnet pack --no-build --configuration Release -o ${{ env.NUGET_OUTPUT }} -p:PackageVersion=${{ steps.increment-version.outputs.next-version }} -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg
-
-      - name: Push NuGet packages
-        if: ${{ steps.context.outputs.should-publish == 'true' }}
-        run: dotnet nuget push --skip-duplicate '${{ env.NUGET_OUTPUT }}/*.nupkg' --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
-
-      - name: Publish NPM packages
-        if: ${{ steps.context.outputs.should-publish == 'true' }}
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
-        run: |
-          yarn publish-version ${{ steps.increment-version.outputs.next-version }}
-
       - name: Commit any updated packages
         if: always()
         run: |

diff --git a/Source/DotNET/Backend/GraphQL/Validation/ValidationMiddleware.cs b/Source/DotNET/Backend/GraphQL/Validation/ValidationMiddleware.cs
@@ -45,7 +45,7 @@ public async Task InvokeAsync(IMiddlewareContext context)
                         await CheckAndValidate(context, instance, argument.RuntimeType, errors, argument.Name).ConfigureAwait(false);
                         if (errors.Count > 0)
                         {
-                            context.Result = "errors";
+                            context.Result = errors;
                             return;
                         }
                     }