This repository has been archived by the owner on Oct 28, 2020. It is now read-only.
feat: log version, module, and files #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yowainwright
suggested changes
Sep 8, 2018
There was a problem hiding this comment.
@brandonocasey awesome stuff!
I noticed a few things. Fix those and we're good to go. 💪
index.js
Outdated
| @@ -106,6 +106,8 @@ prog | |||
| const acornOpts = { ecmaVersion: e, silent: true } | |||
| if (esmodule) { acornOpts.sourceType = 'module'} | |||
|
|
|||
| logger.debug(`ES-Check: Going to check files using version ${e} with module = ${esmodule || 'false'}`) | |||
There was a problem hiding this comment.
logger.debug(`ES-Check: Going to check files using version ${e}${esmodule ? ' with esmodule set' : ''}`)
index.js
Outdated
| @@ -114,6 +116,8 @@ prog | |||
|
|
|||
| globbedFiles.forEach((file) => { | |||
| const code = fs.readFileSync(file, 'utf8') | |||
|
|
|||
| logger.debug(`ES-Check: checking ${file} `) | |||
There was a problem hiding this comment.
Remove space after ${file}.
yowainwright
approved these changes
Sep 9, 2018
|
@brandonocasey, thanks for this thoughtful PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I saw that there was a verbose option and I think that it would be useful to print the files checked, the version checked with, and if module was used or not.