Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on GUARDIAN_FLAG_DOGSTATSD_ADDRESS #33

Open
cleanshavenalex opened this issue Oct 22, 2019 · 0 comments
Open

Remove dependency on GUARDIAN_FLAG_DOGSTATSD_ADDRESS #33

cleanshavenalex opened this issue Oct 22, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@cleanshavenalex
Copy link

When Guardian is deployed with a URL for GUARDIAN_FLAG_DOGSTATSD_ADDRESS
And that URL cannot resolve
Then Guardian should use a NullReporter
And Log that it is not collecting metrics
https://github.com/dollarshaveclub/guardian/blob/master/cmd/guardian/main.go#L69-L73

If the URL GUARDIAN_FLAG_DOGSTATSD_ADDRESS cannot be resolved for any reason Guardian will enter a CrashLoop, this may be expected and acceptable. However I do believe that if URL GUARDIAN_FLAG_DOGSTATSD_ADDRESS experiences issues after Guardian is successfully started, Guardian will fail to handle requests resulting in 'backend not found' ingress response to clients.

@bkeroackdsc bkeroackdsc added the bug Something isn't working label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants