Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop logs in production builds #54

Closed
Andarist opened this issue Feb 27, 2018 · 1 comment · Fixed by #55
Closed

Drop logs in production builds #54

Andarist opened this issue Feb 27, 2018 · 1 comment · Fixed by #55
Labels
enhancement

Comments

@Andarist
Copy link
Contributor

Would you accept PR removing logs in production builds? I would simply wrap all logs with (if (process.env.NODE !== 'production')). This would save us 294 bytes, I suspect you do need those debugs only in dev mode.
@yowainwright
Copy link
Contributor

Let's do it!

@Andarist Andarist mentioned this issue Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrapped every log in process.env.NODE_ENV check for better minificati… Andarist/postmate
2 participants
@yowainwright @Andarist