Tests now pass on MsWin32 platforms #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alabamapaul
commented
Jan 12, 2016
alabamapaul
commented
- Updated git.t to use binmode() to avoid newline translation to/from LF to CRLF. This allows the tests to pass on the MsWin32 platform
- Verified tests pass on:
- Windows 7, 64-bit [(v5.20.1) built for MSWin32-x86-multi-thread-64int]
- Ubuntu 14.04 LTS [(v5.18.2) built for x86_64-gnu-thread-multi]
- Added more descriptions to the test names
chorny
approved these changes
Oct 14, 2016
dolmen
approved these changes
Oct 17, 2016
dolmen
added a commit
that referenced
this pull request
Oct 18, 2016
|
I'm sorry to have not noticed your pull request before. It is merged now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.