Install project dependencies #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the latest master of keystone-deploy, an error is thrown when ansible attempts to sync the keystone database (keystone-manage db_sync). The command errors out saying there is no oslo_config module, even though oslo.config is listed as a dependency in keystone's requirements.txt file. I believe this should be done when the project is installed using `python setup.py install` prior to running the migration but I'm not sure why oslo_config isn't found. This commit just adds an ansible play to manually install the project requirements.txt files using pip before the migration is run.
Since we are running CI on Travis and Ubuntu 12.04 images, we are also running Apache 2.2. There is some logic in our plays that makes some Apache 2.4 assumption. This commit adds logic to make Apache happy when running keystone-deploy against Ubuntu 12.04 or Ubuntu 14.04.
lbragstad
force-pushed
the
install-project-deps
branch
from
f844946
to
33fc63c
Compare
| @@ -31,7 +31,8 @@ | |||
|
|
|||
| - name: enable mpm_prefork | |||
| command: a2enmod mpm_prefork | |||
| when: not mpm_prefork.stat.exists | |||
| when: not mpm_prefork.stat.exists and | |||
| (ansible_lsb.id == "Ubuntu" and ansible_lsb.release == "14.04") | |||
There was a problem hiding this comment.
apparently mpm_prefork is the default for apache 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the latest master of keystone-deploy, an error is thrown when
ansible attempts to sync the keystone database (keystone-manage db_sync). The
command errors out saying there is no oslo_config module, even though
oslo.config is listed as a dependency in keystone's requirements.txt file. I
believe this should be done when the project is installed using
python setup.py installprior to running the migration but I'm not sure whyoslo_config isn't found.
This commit just adds an ansible play to manually install the project
requirements.txt files using pip before the migration is run.