Skip to content

Commit

Permalink
Merge pull request #5074 from lioncash/prefix
Browse files Browse the repository at this point in the history
HW/DSP: Remove prefixed underscores from parameter names
  • Loading branch information
degasus committed Mar 13, 2017
2 parents 8035270 + f183d67 commit 2c308b7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
16 changes: 7 additions & 9 deletions Source/Core/Core/HW/DSP.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -582,27 +582,25 @@ static void Do_ARAM_DMA()
// (shuffle2) I still don't believe that this hack is actually needed... :(
// Maybe the Wii Sports ucode is processed incorrectly?
// (LM) It just means that DSP reads via '0xffdd' on Wii can end up in EXRAM or main RAM
u8 ReadARAM(u32 _iAddress)
u8 ReadARAM(u32 address)
{
// NOTICE_LOG(DSPINTERFACE, "ReadARAM 0x%08x", _iAddress);
if (s_ARAM.wii_mode)
{
if (_iAddress & 0x10000000)
return s_ARAM.ptr[_iAddress & s_ARAM.mask];
if (address & 0x10000000)
return s_ARAM.ptr[address & s_ARAM.mask];
else
return Memory::Read_U8(_iAddress & Memory::RAM_MASK);
return Memory::Read_U8(address & Memory::RAM_MASK);
}
else
{
return s_ARAM.ptr[_iAddress & s_ARAM.mask];
return s_ARAM.ptr[address & s_ARAM.mask];
}
}

void WriteARAM(u8 value, u32 _uAddress)
void WriteARAM(u8 value, u32 address)
{
// NOTICE_LOG(DSPINTERFACE, "WriteARAM 0x%08x", _uAddress);
// TODO: verify this on Wii
s_ARAM.ptr[_uAddress & s_ARAM.mask] = value;
s_ARAM.ptr[address & s_ARAM.mask] = value;
}

u8* GetARAMPtr()
Expand Down
8 changes: 4 additions & 4 deletions Source/Core/Core/HW/DSP.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ union UDSPControl
u16 DSPInit : 1; // DSPInit() writes to this flag
u16 pad : 4;
};
UDSPControl(u16 _Hex = 0) : Hex(_Hex) {}
UDSPControl(u16 hex = 0) : Hex(hex) {}
};

void Init(bool hle);
Expand All @@ -69,11 +69,11 @@ DSPEmulator* GetDSPEmulator();

void DoState(PointerWrap& p);

void GenerateDSPInterruptFromDSPEmu(DSPInterruptType _DSPInterruptType);
void GenerateDSPInterruptFromDSPEmu(DSPInterruptType type);

// Audio/DSP Helper
u8 ReadARAM(const u32 _uAddress);
void WriteARAM(u8 value, u32 _uAddress);
u8 ReadARAM(u32 address);
void WriteARAM(u8 value, u32 address);

// Debugger Helper
u8* GetARAMPtr();
Expand Down

0 comments on commit 2c308b7

Please sign in to comment.