Merge pull request #2945 from lioncash/alloca

ActionReplay: Remove an alloca call
dolphin-emu · Sep 3, 2015 · 34c7f34 · 34c7f34
2 parents 3b65c40 + 2d224bd
commit 34c7f34
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/Source/Core/Core/ActionReplay.cpp b/Source/Core/Core/ActionReplay.cpp
@@ -229,16 +229,14 @@ static void LogInfo(const char *format, ...)
 	{
 		if (LogManager::GetMaxLevel() >= LogTypes::LINFO || logSelf)
 		{
-			char* temp = (char*)alloca(strlen(format)+512);
 			va_list args;
 			va_start(args, format);
-			CharArrayFromFormatV(temp, 512, format, args);
+			std::string text = StringFromFormatV(format, args);
 			va_end(args);
-			INFO_LOG(ACTIONREPLAY, "%s", temp);
+			INFO_LOG(ACTIONREPLAY, "%s", text.c_str());
 
 			if (logSelf)
 			{
-				std::string text = temp;
 				text += '\n';
 				arLog.push_back(text);
 			}