Skip to content

Commit

Permalink
Implement a simple benchmarking mode which logs FPS to a file
Browse files Browse the repository at this point in the history
Very useful to compare performance between two builds, check the impact of
a configuration option, etc. FPS log is stored in User/Logs/fps.txt and is
reset each time you launch a game. Only enabled if you check the "Log FPS
to file" option in your graphics settings.

Could be improved a bit: currently logs only every 1s (so you can't really
see small variations), maybe output more infos to the fps.txt like
average/stddev (but Excel/Libreoffice/Google Docs can compute that easily
too).
  • Loading branch information
delroth committed Oct 4, 2012
1 parent ac2ce8b commit 8cefcaa
Show file tree
Hide file tree
Showing 11 changed files with 119 additions and 36 deletions.
2 changes: 2 additions & 0 deletions Source/Core/DolphinWX/Src/VideoConfigDiag.cpp
Expand Up @@ -98,6 +98,7 @@ wxString wireframe_desc = wxTRANSLATE("Render the scene as a wireframe.\n\nIf un
wxString disable_fog_desc = wxTRANSLATE("Improves performance but causes glitches in most games which rely on proper fog emulation.\n\nIf unsure, leave this unchecked.");
wxString disable_alphapass_desc = wxTRANSLATE("Skip the destination alpha pass used in many games for various graphical effects.\n\nIf unsure, leave this unchecked.");
wxString show_fps_desc = wxTRANSLATE("Show the number of frames rendered per second as a measure of emulation speed.\n\nIf unsure, leave this unchecked.");
wxString log_fps_to_file_desc = wxTRANSLATE("Log the number of frames rendered per second to User/Logs/fps.txt. Use this feature when you want to measure the performance of Dolphin.\n\nIf unsure, leave this unchecked.");
wxString show_input_display_desc = wxTRANSLATE("Display the inputs read by the emulator.\n\nIf unsure, leave this unchecked.");
wxString show_stats_desc = wxTRANSLATE("Show various statistics.\n\nIf unsure, leave this unchecked.");
wxString texfmt_desc = wxTRANSLATE("Modify textures to show the format they're encoded in. Needs an emulation reset in most cases.\n\nIf unsure, leave this unchecked.");
Expand Down Expand Up @@ -296,6 +297,7 @@ VideoConfigDiag::VideoConfigDiag(wxWindow* parent, const std::string &title, con
{
SettingCheckBox* render_to_main_cb;
szr_other->Add(CreateCheckBox(page_general, _("Show FPS"), wxGetTranslation(show_fps_desc), vconfig.bShowFPS));
szr_other->Add(CreateCheckBox(page_general, _("Log FPS to file"), wxGetTranslation(log_fps_to_file_desc), vconfig.bLogFPSToFile));
szr_other->Add(CreateCheckBox(page_general, _("Auto adjust Window Size"), wxGetTranslation(auto_window_size_desc), SConfig::GetInstance().m_LocalCoreStartupParameter.bRenderWindowAutoSize));
szr_other->Add(CreateCheckBox(page_general, _("Keep window on top"), wxGetTranslation(keep_window_on_top_desc), SConfig::GetInstance().m_LocalCoreStartupParameter.bKeepWindowOnTop));
szr_other->Add(CreateCheckBox(page_general, _("Hide Mouse Cursor"), wxGetTranslation(hide_mouse_cursor_desc), SConfig::GetInstance().m_LocalCoreStartupParameter.bHideCursor));
Expand Down
1 change: 1 addition & 0 deletions Source/Core/VideoCommon/CMakeLists.txt
Expand Up @@ -6,6 +6,7 @@ set(SRCS Src/BPFunctions.cpp
Src/DLCache.cpp
Src/Debugger.cpp
Src/Fifo.cpp
Src/FPSCounter.cpp
Src/FramebufferManagerBase.cpp
Src/HiresTextures.cpp
Src/ImageWrite.cpp
Expand Down
64 changes: 64 additions & 0 deletions Source/Core/VideoCommon/Src/FPSCounter.cpp
@@ -0,0 +1,64 @@
// Copyright (C) 2003 Dolphin Project.

// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, version 2.0.

// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License 2.0 for more details.

// A copy of the GPL 2.0 should have been included with the program.
// If not, see http://www.gnu.org/licenses/

// Official SVN repository and contact information can be found at
// http://code.google.com/p/dolphin-emu/

#include "FPSCounter.h"
#include "FileUtil.h"
#include "Timer.h"
#include "VideoConfig.h"

#define FPS_REFRESH_INTERVAL 1000

static unsigned int s_counter = 0;
static unsigned int s_fps = 0;
static unsigned int s_fps_last_counter = 0;
static unsigned long s_last_update_time = 0;
static File::IOFile s_bench_file;

void InitFPSCounter()
{
s_counter = s_fps_last_counter = 0;
s_fps = 0;
s_last_update_time = Common::Timer::GetTimeMs();

if (s_bench_file.IsOpen())
s_bench_file.Close();
}

static void LogFPSToFile(unsigned long val)
{
if (!s_bench_file.IsOpen())
s_bench_file.Open(File::GetUserPath(D_LOGS_IDX) + "fps.txt", "w");

char buffer[256];
snprintf(buffer, 256, "%ld\n", val);
s_bench_file.WriteArray(buffer, strlen(buffer));
}

int UpdateFPSCounter()
{
if (Common::Timer::GetTimeMs() - s_last_update_time >= FPS_REFRESH_INTERVAL)
{
s_last_update_time = Common::Timer::GetTimeMs();
s_fps = s_counter - s_fps_last_counter;
s_fps_last_counter = s_counter;
if (g_ActiveConfig.bLogFPSToFile)
LogFPSToFile(s_fps);
}

s_counter++;
return s_fps;
}
28 changes: 28 additions & 0 deletions Source/Core/VideoCommon/Src/FPSCounter.h
@@ -0,0 +1,28 @@
// Copyright (C) 2003 Dolphin Project.

// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, version 2.0.

// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License 2.0 for more details.

// A copy of the GPL 2.0 should have been included with the program.
// If not, see http://www.gnu.org/licenses/

// Official SVN repository and contact information can be found at
// http://code.google.com/p/dolphin-emu/

#ifndef _FPS_COUNTER_H_
#define _FPS_COUNTER_H_

// Initializes the FPS counter.
void InitFPSCounter();

// Called when a frame is rendered. Returns the value to be displayed on
// screen as the FPS counter (updated every second).
int UpdateFPSCounter();

#endif // _FPS_COUNTER_H_
2 changes: 2 additions & 0 deletions Source/Core/VideoCommon/Src/VideoConfig.cpp
Expand Up @@ -59,6 +59,7 @@ void VideoConfig::Load(const char *ini_file)
iniFile.Get("Settings", "UseRealXFB", &bUseRealXFB, 0);
iniFile.Get("Settings", "SafeTextureCacheColorSamples", &iSafeTextureCache_ColorSamples,128);
iniFile.Get("Settings", "ShowFPS", &bShowFPS, false); // Settings
iniFile.Get("Settings", "LogFPSToFile", &bLogFPSToFile, false);
iniFile.Get("Settings", "ShowInputDisplay", &bShowInputDisplay, false);
iniFile.Get("Settings", "OverlayStats", &bOverlayStats, false);
iniFile.Get("Settings", "OverlayProjStats", &bOverlayProjStats, false);
Expand Down Expand Up @@ -186,6 +187,7 @@ void VideoConfig::Save(const char *ini_file)
iniFile.Set("Settings", "UseRealXFB", bUseRealXFB);
iniFile.Set("Settings", "SafeTextureCacheColorSamples", iSafeTextureCache_ColorSamples);
iniFile.Set("Settings", "ShowFPS", bShowFPS);
iniFile.Set("Settings", "LogFPSToFile", bLogFPSToFile);
iniFile.Set("Settings", "ShowInputDisplay", bShowInputDisplay);
iniFile.Set("Settings", "OverlayStats", bOverlayStats);
iniFile.Set("Settings", "OverlayProjStats", bOverlayProjStats);
Expand Down
1 change: 1 addition & 0 deletions Source/Core/VideoCommon/Src/VideoConfig.h
Expand Up @@ -97,6 +97,7 @@ struct VideoConfig
bool bTexFmtOverlayEnable;
bool bTexFmtOverlayCenter;
bool bShowEFBCopyRegions;
bool bLogFPSToFile;

// Render
bool bWireFrame;
Expand Down
2 changes: 2 additions & 0 deletions Source/Core/VideoCommon/VideoCommon.vcxproj
Expand Up @@ -183,6 +183,7 @@
<ClCompile Include="Src\DLCache.cpp" />
<ClCompile Include="Src\EmuWindow.cpp" />
<ClCompile Include="Src\Fifo.cpp" />
<ClCompile Include="Src\FPSCounter.cpp" />
<ClCompile Include="Src\FramebufferManagerBase.cpp" />
<ClCompile Include="Src\HiresTextures.cpp" />
<ClCompile Include="Src\ImageWrite.cpp" />
Expand Down Expand Up @@ -228,6 +229,7 @@
<ClInclude Include="Src\DLCache.h" />
<ClInclude Include="Src\EmuWindow.h" />
<ClInclude Include="Src\Fifo.h" />
<ClInclude Include="Src\FPSCounter.h" />
<ClInclude Include="Src\FramebufferManagerBase.h" />
<ClInclude Include="Src\HiresTextures.h" />
<ClInclude Include="Src\ImageWrite.h" />
Expand Down
6 changes: 6 additions & 0 deletions Source/Core/VideoCommon/VideoCommon.vcxproj.filters
Expand Up @@ -119,6 +119,9 @@
<ClCompile Include="Src\LightingShaderGen.cpp">
<Filter>Shader Generators</Filter>
</ClCompile>
<ClCompile Include="Src\FPSCounter.cpp">
<Filter>Util</Filter>
</ClCompile>
</ItemGroup>
<ItemGroup>
<ClInclude Include="Src\CommandProcessor.h" />
Expand Down Expand Up @@ -246,6 +249,9 @@
<ClInclude Include="Src\LightingShaderGen.h">
<Filter>Shader Generators</Filter>
</ClInclude>
<ClInclude Include="Src\FPSCounter.h">
<Filter>Util</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
<None Include="CMakeLists.txt" />
Expand Down
13 changes: 4 additions & 9 deletions Source/Plugins/Plugin_VideoDX11/Src/Render.cpp
Expand Up @@ -44,6 +44,7 @@
#include "Host.h"
#include "BPFunctions.h"
#include "AVIDump.h"
#include "FPSCounter.h"

namespace DX11
{
Expand Down Expand Up @@ -338,6 +339,8 @@ Renderer::Renderer()
int x, y, w_temp, h_temp;
s_blendMode = 0;

InitFPSCounter();

Host_GetRenderWindowSize(x, y, w_temp, h_temp);

D3D::Create(EmuWindow::GetWnd());
Expand Down Expand Up @@ -1143,16 +1146,8 @@ void Renderer::Swap(u32 xfbAddr, FieldType field, u32 fbWidth, u32 fbHeight,cons
}

// update FPS counter
static int fpscount = 0;
static unsigned long lasttime = 0;
if (Common::Timer::GetTimeMs() - lasttime >= 1000)
{
lasttime = Common::Timer::GetTimeMs();
s_fps = fpscount;
fpscount = 0;
}
if (XFBWrited)
++fpscount;
s_fps = UpdateFPSCounter();

// Begin new frame
// Set default viewport and scissor, for the clear to work correctly
Expand Down
19 changes: 5 additions & 14 deletions Source/Plugins/Plugin_VideoDX9/Src/Render.cpp
Expand Up @@ -54,6 +54,7 @@
#include "Core.h"
#include "Movie.h"
#include "BPFunctions.h"
#include "FPSCounter.h"

namespace DX9
{
Expand Down Expand Up @@ -247,6 +248,8 @@ void TeardownDeviceObjects()
// Init functions
Renderer::Renderer()
{
InitFPSCounter();

st = new char[32768];

int fullScreenRes, x, y, w_temp, h_temp;
Expand Down Expand Up @@ -1107,7 +1110,7 @@ void Renderer::Swap(u32 xfbAddr, FieldType field, u32 fbWidth, u32 fbHeight,cons

OSD::DrawMessages();
D3D::EndFrame();
frameCount++;
++frameCount;

GFX_DEBUGGER_PAUSE_AT(NEXT_FRAME, true);

Expand Down Expand Up @@ -1168,20 +1171,8 @@ void Renderer::Swap(u32 xfbAddr, FieldType field, u32 fbWidth, u32 fbHeight,cons
D3D::dev->Clear(0, NULL, D3DCLEAR_TARGET | D3DCLEAR_ZBUFFER, D3DCOLOR_XRGB(0,0,0), 1.0f, 0);
}

// Place messages on the picture, then copy it to the screen
// ---------------------------------------------------------------------
// Count FPS.
// -------------
static int fpscount = 0;
static unsigned long lasttime = 0;
if (Common::Timer::GetTimeMs() - lasttime >= 1000)
{
lasttime = Common::Timer::GetTimeMs();
s_fps = fpscount;
fpscount = 0;
}
if (XFBWrited)
++fpscount;
s_fps = UpdateFPSCounter();

// Begin new frame
// Set default viewport and scissor, for the clear to work correctly
Expand Down
17 changes: 4 additions & 13 deletions Source/Plugins/Plugin_VideoOGL/Src/Render.cpp
Expand Up @@ -61,6 +61,7 @@
#include "Movie.h"
#include "Host.h"
#include "BPFunctions.h"
#include "FPSCounter.h"

#include "main.h" // Local
#ifdef _WIN32
Expand Down Expand Up @@ -251,6 +252,8 @@ Renderer::Renderer()
s_fps=0;
s_blendMode = 0;

InitFPSCounter();

#if defined HAVE_CG && HAVE_CG
g_cgcontext = cgCreateContext();
cgGetError();
Expand Down Expand Up @@ -1330,20 +1333,8 @@ void Renderer::Swap(u32 xfbAddr, FieldType field, u32 fbWidth, u32 fbHeight,cons
}
}

// Place messages on the picture, then copy it to the screen
// ---------------------------------------------------------------------
// Count FPS.
// -------------
static int fpscount = 0;
static unsigned long lasttime = 0;
if (Common::Timer::GetTimeMs() - lasttime >= 1000)
{
lasttime = Common::Timer::GetTimeMs();
s_fps = fpscount;
fpscount = 0;
}
if (XFBWrited)
++fpscount;
s_fps = UpdateFPSCounter();
// ---------------------------------------------------------------------
GL_REPORT_ERRORD();

Expand Down

0 comments on commit 8cefcaa

Please sign in to comment.