Skip to content

Commit

Permalink
Android: Increase targetSdkVersion to 29
Browse files Browse the repository at this point in the history
Since updating to 28 took us so long that Google Play started
requiring updates to target 28 before we actually merged the PR that
made us target 28, I'm trying to get the update to 29 done early.

Setting targetSdkVersion to 28 would normally force scoped storage
on us, which we do not support yet. However, we can easily
avoid this by setting android:requestLegacyExternalStorage="true".
There will be no such luxury with targetSdkVersion 30, however...
  • Loading branch information
JosJuice committed Jul 12, 2020
1 parent ed32a2a commit 95945a0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Source/Android/app/build.gradle
Expand Up @@ -22,7 +22,7 @@ android {
// TODO If this is ever modified, change application_id in strings.xml
applicationId "org.dolphinemu.dolphinemu"
minSdkVersion 21
targetSdkVersion 28
targetSdkVersion 29

versionCode(getBuildVersionCode())

Expand Down
1 change: 1 addition & 0 deletions Source/Android/app/src/main/AndroidManifest.xml
Expand Up @@ -32,6 +32,7 @@
android:name=".DolphinApplication"
android:label="@string/app_name"
android:icon="@drawable/ic_launcher"
android:requestLegacyExternalStorage="true"
android:allowBackup="false"
android:supportsRtl="true"
android:isGame="true"
Expand Down

0 comments on commit 95945a0

Please sign in to comment.