Improve comments on the Resident Evil 2/3 patches

Replace the single line comment in the game .ini with one that lays out the bigger picture. Summary courtesy of phire. :)
dolphin-emu · Dec 26, 2020 · a7f0fb3 · a7f0fb3
1 parent 85d42a9
commit a7f0fb3
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 6 deletions.
diff --git a/Data/Sys/GameSettings/GHAE08.ini b/Data/Sys/GameSettings/GHAE08.ini
@@ -1,7 +1,10 @@
 # GHAE08 - Resident Evil 2
 
 [OnFrame]
-# Skip memset call that is followed by dcbi, simulating dcache behavior
+# Work around a game bug that causes background sounds to be zeroed during load.
+# The bug was masked on real hardware by dcache. This patch fully fixes the bug
+# and should also work on real hardware. Dolphin doesn't emulate dcache because
+# the performance hit would be huge.
 $Fix audio issues
 # main.dol
 0x800339E4:dword:0x60000000

diff --git a/Data/Sys/GameSettings/GHAJ08.ini b/Data/Sys/GameSettings/GHAJ08.ini
@@ -1,7 +1,10 @@
 # GHAJ08 - Biohazard 2
 
 [OnFrame]
-# Skip memset call that is followed by dcbi, simulating dcache behavior
+# Work around a game bug that causes background sounds to be zeroed during load.
+# The bug was masked on real hardware by dcache. This patch fully fixes the bug
+# and should also work on real hardware. Dolphin doesn't emulate dcache because
+# the performance hit would be huge.
 $Fix audio issues
 # main.dol
 0x80065FFC:dword:0x60000000

diff --git a/Data/Sys/GameSettings/GHAP08.ini b/Data/Sys/GameSettings/GHAP08.ini
@@ -1,7 +1,10 @@
 # GHAP08 - Resident Evil 2
 
 [OnFrame]
-# Skip memset call that is followed by dcbi, simulating dcache behavior
+# Work around a game bug that causes background sounds to be zeroed during load.
+# The bug was masked on real hardware by dcache. This patch fully fixes the bug
+# and should also work on real hardware. Dolphin doesn't emulate dcache because
+# the performance hit would be huge.
 $Fix audio issues
 # main.dol
 0x80033D60:dword:0x60000000

diff --git a/Data/Sys/GameSettings/GLEE08.ini b/Data/Sys/GameSettings/GLEE08.ini
@@ -1,7 +1,10 @@
 # GLEE08 - Resident Evil 3: Nemesis
 
 [OnFrame]
-# Skip memset call that is followed by dcbi, simulating dcache behavior
+# Work around a game bug that causes background sounds to be zeroed during load.
+# The bug was masked on real hardware by dcache. This patch fully fixes the bug
+# and should also work on real hardware. Dolphin doesn't emulate dcache because
+# the performance hit would be huge.
 $Fix audio issues
 # main.dol
 0x80150E94:dword:0x60000000

diff --git a/Data/Sys/GameSettings/GLEJ08.ini b/Data/Sys/GameSettings/GLEJ08.ini
@@ -1,7 +1,10 @@
 # GLEJ08 - BioHazard 3: Last Escape
 
 [OnFrame]
-# Skip memset call that is followed by dcbi, simulating dcache behavior
+# Work around a game bug that causes background sounds to be zeroed during load.
+# The bug was masked on real hardware by dcache. This patch fully fixes the bug
+# and should also work on real hardware. Dolphin doesn't emulate dcache because
+# the performance hit would be huge.
 $Fix audio issues
 # main.dol
 0x8015110C:dword:0x60000000

diff --git a/Data/Sys/GameSettings/GLEP08.ini b/Data/Sys/GameSettings/GLEP08.ini
@@ -1,7 +1,10 @@
 # GLEP08 - Resident Evil 3: Nemesis
 
 [OnFrame]
-# Skip memset call that is followed by dcbi, simulating dcache behavior
+# Work around a game bug that causes background sounds to be zeroed during load.
+# The bug was masked on real hardware by dcache. This patch fully fixes the bug
+# and should also work on real hardware. Dolphin doesn't emulate dcache because
+# the performance hit would be huge.
 $Fix audio issues
 # eng.rel
 0x8058C174:dword:0x60000000:0x4BA76F8D