Merge pull request #9568 from JosJuice/android-delay-save-tab

Android: Don't save settings immediately after switching platform tab
dolphin-emu · Mar 7, 2021 · ac687bc · ac687bc
2 parents a5555c6 + 13cc327
commit ac687bc
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 10 deletions.
diff --git a/...d/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java b/...d/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java
@@ -279,4 +279,9 @@ public boolean getBooleanGlobal()
   {
     return NativeConfig.getBoolean(NativeConfig.LAYER_ACTIVE, mFile, mSection, mKey, mDefaultValue);
   }
+
+  public void setBooleanGlobal(int layer, boolean newValue)
+  {
+    NativeConfig.setBoolean(layer, mFile, mSection, mKey, newValue);
+  }
 }
diff --git a/...oid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/FloatSetting.java b/...oid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/FloatSetting.java
@@ -78,4 +78,9 @@ public float getFloatGlobal()
   {
     return NativeConfig.getFloat(NativeConfig.LAYER_ACTIVE, mFile, mSection, mKey, mDefaultValue);
   }
+
+  public void setFloatGlobal(int layer, float newValue)
+  {
+    NativeConfig.setFloat(layer, mFile, mSection, mKey, newValue);
+  }
 }
diff --git a/...droid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/IntSetting.java b/...droid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/IntSetting.java
@@ -147,4 +147,9 @@ public int getIntGlobal()
   {
     return NativeConfig.getInt(NativeConfig.LAYER_ACTIVE, mFile, mSection, mKey, mDefaultValue);
   }
+
+  public void setIntGlobal(int layer, int newValue)
+  {
+    NativeConfig.setInt(layer, mFile, mSection, mKey, newValue);
+  }
 }
diff --git a/...id/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/StringSetting.java b/...id/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/StringSetting.java
@@ -109,4 +109,9 @@ public String getStringGlobal()
   {
     return NativeConfig.getString(NativeConfig.LAYER_ACTIVE, mFile, mSection, mKey, mDefaultValue);
   }
+
+  public void setStringGlobal(int layer, String newValue)
+  {
+    NativeConfig.setString(layer, mFile, mSection, mKey, newValue);
+  }
 }
diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainActivity.java
@@ -23,6 +23,7 @@
 import org.dolphinemu.dolphinemu.activities.EmulationActivity;
 import org.dolphinemu.dolphinemu.adapters.PlatformPagerAdapter;
 import org.dolphinemu.dolphinemu.features.settings.model.IntSetting;
+import org.dolphinemu.dolphinemu.features.settings.model.NativeConfig;
 import org.dolphinemu.dolphinemu.features.settings.model.Settings;
 import org.dolphinemu.dolphinemu.features.settings.ui.MenuTag;
 import org.dolphinemu.dolphinemu.features.settings.ui.SettingsActivity;
@@ -113,10 +114,17 @@ protected void onStart()
   protected void onStop()
   {
     super.onStop();
+
     if (isChangingConfigurations())
     {
       MainPresenter.skipRescanningLibrary();
     }
+    else if (DirectoryInitialization.areDolphinDirectoriesReady())
+    {
+      // If the currently selected platform tab changed, save it to disk
+      NativeConfig.save(NativeConfig.LAYER_BASE);
+    }
+
     StartupHandler.setSessionTime(this);
   }
 
@@ -321,16 +329,7 @@ private void setPlatformTabsAndStartGameFileCacheService()
       public void onTabSelected(@NonNull TabLayout.Tab tab)
       {
         super.onTabSelected(tab);
-
-        try (Settings settings = new Settings())
-        {
-          settings.loadSettings();
-
-          IntSetting.MAIN_LAST_PLATFORM_TAB.setInt(settings, tab.getPosition());
-
-          // Context is set to null to avoid toasts
-          settings.saveSettings(null, null);
-        }
+        IntSetting.MAIN_LAST_PLATFORM_TAB.setIntGlobal(NativeConfig.LAYER_BASE, tab.getPosition());
       }
     });