Address PR feedback

dolphin-emu · Dec 5, 2020 · c3741c6 · c3741c6
1 parent 9ea0e22
commit c3741c6
Showing 1 changed file with 6 additions and 24 deletions.
diff --git a/Source/Core/Core/PatchEngine.cpp b/Source/Core/Core/PatchEngine.cpp
@@ -200,34 +200,16 @@ static void ApplyPatches(const std::vector<Patch>& patches)
         switch (entry.type)
         {
         case PatchType::Patch8Bit:
-          if (entry.conditional)
-          {
-            if (PowerPC::HostRead_U8(addr) != static_cast<u8>(comparand))
-            {
-              break;
-            }
-          }
-          PowerPC::HostWrite_U8(static_cast<u8>(value), addr);
+          if (!entry.conditional || PowerPC::HostRead_U8(addr) == static_cast<u8>(comparand))
+            PowerPC::HostWrite_U8(static_cast<u8>(value), addr);
           break;
         case PatchType::Patch16Bit:
-          if (entry.conditional)
-          {
-            if (PowerPC::HostRead_U16(addr) != static_cast<u16>(comparand))
-            {
-              break;
-            }
-          }
-          PowerPC::HostWrite_U16(static_cast<u16>(value), addr);
+          if (!entry.conditional || PowerPC::HostRead_U16(addr) == static_cast<u16>(comparand))
+            PowerPC::HostWrite_U16(static_cast<u16>(value), addr);
           break;
         case PatchType::Patch32Bit:
-          if (entry.conditional)
-          {
-            if (PowerPC::HostRead_U32(addr) != comparand)
-            {
-              break;
-            }
-          }
-          PowerPC::HostWrite_U32(value, addr);
+          if (!entry.conditional || PowerPC::HostRead_U32(addr) == comparand)
+            PowerPC::HostWrite_U32(value, addr);
           break;
         default:
           // unknown patchtype