Make ref m_array and m_index const

They still aren't trivially copyable, but don't seem to actually need to be (and BitFieldArrayRef can't be, because it needs to replace assignment with changing the array).

Source/Core/Common/BitField.h

@@ -321,8 +321,6 @@ class BitFieldArrayConstRef
   friend class BitFieldArrayConstIterator<position, bits, size, T, S>;
 
 public:
-  constexpr BitFieldArrayConstRef(BitFieldArrayConstRef&& other) = default;
-
   constexpr T Value() const { return m_array->Value(m_index); };
   constexpr operator T() const { return Value(); }
 
@@ -333,10 +331,8 @@ class BitFieldArrayConstRef
   {
   }
 
-  // TODO: making these const causes the type to no longer by trivially copyable in MSVC for some
-  // reason
-  const BitFieldArray<position, bits, size, T, S>* m_array;
-  size_t m_index;
+  const BitFieldArray<position, bits, size, T, S>* const m_array;
+  const size_t m_index;
 };
 
 template <std::size_t position, std::size_t bits, std::size_t size, typename T, typename S>
@@ -346,8 +342,6 @@ class BitFieldArrayRef
   friend class BitFieldArrayIterator<position, bits, size, T, S>;
 
 public:
-  constexpr BitFieldArrayRef(BitFieldArrayRef&& other) = default;
-
   constexpr T Value() const { return m_array->Value(m_index); };
   constexpr operator T() const { return Value(); }
   T operator=(const BitFieldArrayRef<position, bits, size, T, S>& value) const
@@ -367,10 +361,8 @@ class BitFieldArrayRef
   {
   }
 
-  // TODO: making these const causes the type to no longer by trivially copyable in MSVC for some
-  // reason
-  BitFieldArray<position, bits, size, T, S>* m_array;
-  size_t m_index;
+  BitFieldArray<position, bits, size, T, S>* const m_array;
+  const size_t m_index;
 };
 
 // Satisfies LegacyOutputIterator / std::output_iterator.
@@ -402,6 +394,8 @@ class BitFieldArrayIterator
   constexpr BitFieldArrayIterator() = default;
   // Required by LegacyIterator
   constexpr BitFieldArrayIterator(const BitFieldArrayIterator& other) = default;
+  // Required by LegacyIterator
+  BitFieldArrayIterator& operator=(const BitFieldArrayIterator& other) = default;
 
 public:
   BitFieldArrayIterator& operator++()
@@ -452,6 +446,8 @@ class BitFieldArrayConstIterator
   constexpr BitFieldArrayConstIterator() = default;
   // Required by LegacyIterator
   constexpr BitFieldArrayConstIterator(const BitFieldArrayConstIterator& other) = default;
+  // Required by LegacyIterator
+  BitFieldArrayConstIterator& operator=(const BitFieldArrayConstIterator& other) = default;
 
 public:
   BitFieldArrayConstIterator& operator++()