Android: Create separate InvertedCheckBoxSetting and PercentSliderSet…

…ting classes This way we don't have to hardcode any keys inside the classes.
dolphin-emu · Jul 7, 2020 · dafd967 · dafd967
1 parent 520b1aa
commit dafd967
Show file tree

Hide file tree

Showing 5 changed files with 63 additions and 37 deletions.
diff --git a/...src/main/java/org/dolphinemu/dolphinemu/features/settings/model/view/CheckBoxSetting.java b/...src/main/java/org/dolphinemu/dolphinemu/features/settings/model/view/CheckBoxSetting.java
@@ -1,11 +1,10 @@
 package org.dolphinemu.dolphinemu.features.settings.model.view;
 
 import org.dolphinemu.dolphinemu.features.settings.model.Settings;
-import org.dolphinemu.dolphinemu.features.settings.utils.SettingsFile;
 
-public final class CheckBoxSetting extends SettingsItem
+public class CheckBoxSetting extends SettingsItem
 {
-  private boolean mDefaultValue;
+  protected boolean mDefaultValue;
 
   public CheckBoxSetting(String file, String section, String key, int titleId, int descriptionId,
           boolean defaultValue)
@@ -16,24 +15,12 @@ public CheckBoxSetting(String file, String section, String key, int titleId, int
 
   public boolean isChecked(Settings settings)
   {
-    return invertIfNeeded(settings.getSection(getFile(), getSection())
-            .getBoolean(getKey(), invertIfNeeded(mDefaultValue)));
+    return settings.getSection(getFile(), getSection()).getBoolean(getKey(), mDefaultValue);
   }
 
   public void setChecked(Settings settings, boolean checked)
   {
-    settings.getSection(getFile(), getSection()).setBoolean(getKey(), invertIfNeeded(checked));
-  }
-
-  private boolean invertIfNeeded(boolean x)
-  {
-    return isInverted() ? !x : x;
-  }
-
-  private boolean isInverted()
-  {
-    return getKey().equals(SettingsFile.KEY_SKIP_EFB) ||
-            getKey().equals(SettingsFile.KEY_IGNORE_FORMAT);
+    settings.getSection(getFile(), getSection()).setBoolean(getKey(), checked);
   }
 
   @Override

diff --git a/.../main/java/org/dolphinemu/dolphinemu/features/settings/model/view/FloatSliderSetting.java b/.../main/java/org/dolphinemu/dolphinemu/features/settings/model/view/FloatSliderSetting.java
@@ -1,42 +1,29 @@
 package org.dolphinemu.dolphinemu.features.settings.model.view;
 
 import org.dolphinemu.dolphinemu.features.settings.model.Settings;
-import org.dolphinemu.dolphinemu.features.settings.utils.SettingsFile;
 
-public final class FloatSliderSetting extends SliderSetting
+public class FloatSliderSetting extends SliderSetting
 {
-  private float mDefaultValue;
+  protected float mDefaultValue;
 
   public FloatSliderSetting(String file, String section, String key, int titleId, int descriptionId,
           int max, String units, float defaultValue)
   {
     super(file, section, key, titleId, descriptionId, max, units);
     mDefaultValue = defaultValue;
-
-    if (isPercentSetting())
-      mDefaultValue /= 100;
   }
 
   public int getSelectedValue(Settings settings)
   {
     float value = settings.getSection(getFile(), getSection()).getFloat(getKey(), mDefaultValue);
-    return Math.round(isPercentSetting() ? value * 100 : value);
+    return Math.round(value);
   }
 
   public void setSelectedValue(Settings settings, float selection)
   {
-    if (isPercentSetting())
-      selection /= 100;
-
     settings.getSection(getFile(), getSection()).setFloat(getKey(), selection);
   }
 
-  private boolean isPercentSetting()
-  {
-    return getKey().equals(SettingsFile.KEY_OVERCLOCK_PERCENT)
-            || getKey().equals(SettingsFile.KEY_SPEED_LIMIT);
-  }
-
   @Override
   public int getType()
   {

diff --git a/.../java/org/dolphinemu/dolphinemu/features/settings/model/view/InvertedCheckBoxSetting.java b/.../java/org/dolphinemu/dolphinemu/features/settings/model/view/InvertedCheckBoxSetting.java
@@ -0,0 +1,25 @@
+package org.dolphinemu.dolphinemu.features.settings.model.view;
+
+import org.dolphinemu.dolphinemu.features.settings.model.Settings;
+import org.dolphinemu.dolphinemu.features.settings.utils.SettingsFile;
+
+public final class InvertedCheckBoxSetting extends CheckBoxSetting
+{
+  public InvertedCheckBoxSetting(String file, String section, String key, int titleId,
+          int descriptionId, boolean defaultValue)
+  {
+    super(file, section, key, titleId, descriptionId, !defaultValue);
+  }
+
+  @Override
+  public boolean isChecked(Settings settings)
+  {
+    return !settings.getSection(getFile(), getSection()).getBoolean(getKey(), mDefaultValue);
+  }
+
+  @Override
+  public void setChecked(Settings settings, boolean checked)
+  {
+    settings.getSection(getFile(), getSection()).setBoolean(getKey(), !checked);
+  }
+}
diff --git a/...ain/java/org/dolphinemu/dolphinemu/features/settings/model/view/PercentSliderSetting.java b/...ain/java/org/dolphinemu/dolphinemu/features/settings/model/view/PercentSliderSetting.java
@@ -0,0 +1,25 @@
+package org.dolphinemu.dolphinemu.features.settings.model.view;
+
+import org.dolphinemu.dolphinemu.features.settings.model.Settings;
+
+public final class PercentSliderSetting extends FloatSliderSetting
+{
+  public PercentSliderSetting(String file, String section, String key, int titleId,
+          int descriptionId, int max, String units, float defaultValue)
+  {
+    super(file, section, key, titleId, descriptionId, max, units, defaultValue / 100);
+  }
+
+  @Override
+  public int getSelectedValue(Settings settings)
+  {
+    float value = settings.getSection(getFile(), getSection()).getFloat(getKey(), mDefaultValue);
+    return Math.round(value * 100);
+  }
+
+  @Override
+  public void setSelectedValue(Settings settings, float selection)
+  {
+    settings.getSection(getFile(), getSection()).setFloat(getKey(), selection / 100);
+  }
+}
diff --git a/...c/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java b/...c/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.java
@@ -13,6 +13,8 @@
 import org.dolphinemu.dolphinemu.features.settings.model.view.HeaderSetting;
 import org.dolphinemu.dolphinemu.features.settings.model.view.InputBindingSetting;
 import org.dolphinemu.dolphinemu.features.settings.model.view.IntSliderSetting;
+import org.dolphinemu.dolphinemu.features.settings.model.view.InvertedCheckBoxSetting;
+import org.dolphinemu.dolphinemu.features.settings.model.view.PercentSliderSetting;
 import org.dolphinemu.dolphinemu.features.settings.model.view.RumbleBindingSetting;
 import org.dolphinemu.dolphinemu.features.settings.model.view.SettingsItem;
 import org.dolphinemu.dolphinemu.features.settings.model.view.SingleChoiceSetting;
@@ -232,7 +234,7 @@ private void addGeneralSettings(ArrayList<SettingsItem> sl)
             false));
     sl.add(new CheckBoxSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_INI_CORE,
             SettingsFile.KEY_AUTO_DISC_CHANGE, R.string.auto_disc_change, 0, false));
-    sl.add(new FloatSliderSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_INI_CORE,
+    sl.add(new PercentSliderSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_INI_CORE,
             SettingsFile.KEY_SPEED_LIMIT, R.string.speed_limit, 0, 200, "%", 100));
     sl.add(new CheckBoxSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_ANALYTICS,
             SettingsFile.KEY_ANALYTICS_ENABLED, R.string.analytics, 0, false));
@@ -362,7 +364,7 @@ else if (defaultCpuCore == 4)  // AArch64
     sl.add(new CheckBoxSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_INI_CORE,
             SettingsFile.KEY_OVERCLOCK_ENABLE, R.string.overclock_enable,
             R.string.overclock_enable_description, false));
-    sl.add(new FloatSliderSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_INI_CORE,
+    sl.add(new PercentSliderSetting(SettingsFile.FILE_NAME_DOLPHIN, Settings.SECTION_INI_CORE,
             SettingsFile.KEY_OVERCLOCK_PERCENT, R.string.overclock_title,
             R.string.overclock_title_description, 400, "%", 100));
   }
@@ -549,10 +551,10 @@ private String[] getShaderList(String subDir)
   private void addHackSettings(ArrayList<SettingsItem> sl)
   {
     sl.add(new HeaderSetting(null, R.string.embedded_frame_buffer, 0));
-    sl.add(new CheckBoxSetting(SettingsFile.FILE_NAME_GFX, Settings.SECTION_GFX_HACKS,
+    sl.add(new InvertedCheckBoxSetting(SettingsFile.FILE_NAME_GFX, Settings.SECTION_GFX_HACKS,
             SettingsFile.KEY_SKIP_EFB, R.string.skip_efb_access,
             R.string.skip_efb_access_description, false));
-    sl.add(new CheckBoxSetting(SettingsFile.FILE_NAME_GFX, Settings.SECTION_GFX_HACKS,
+    sl.add(new InvertedCheckBoxSetting(SettingsFile.FILE_NAME_GFX, Settings.SECTION_GFX_HACKS,
             SettingsFile.KEY_IGNORE_FORMAT, R.string.ignore_format_changes,
             R.string.ignore_format_changes_description, true));
     sl.add(new CheckBoxSetting(SettingsFile.FILE_NAME_GFX, Settings.SECTION_GFX_HACKS,