Skip to content

Commit

Permalink
Merge pull request #378 from delroth/interrupts-comments
Browse files Browse the repository at this point in the history
CheckExceptions: add TODO and remove a wrong comment
  • Loading branch information
Sonicadvance1 committed May 17, 2014
2 parents a2d73ed + 0f1b1dd commit db96f86
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion Source/Core/Core/PowerPC/PowerPC.cpp
Expand Up @@ -320,6 +320,11 @@ void CheckExceptions()
// set to exception type entry point
//NPC = 0x00000x00;

// TODO(delroth): Exception priority is completely wrong here: depending on
// the instruction class, exceptions should be executed in a given order,
// which is very different from the one arbitrarily chosen here. See §6.1.5
// in 6xx_pem.pdf.

if (exceptions & EXCEPTION_ISI)
{
SRR0 = NPC;
Expand Down Expand Up @@ -396,7 +401,7 @@ void CheckExceptions()
}

// EXTERNAL INTERRUPT
else if (MSR & 0x0008000) //hacky...the exception shouldn't be generated if EE isn't set...
else if (MSR & 0x0008000) // Handling is delayed until MSR.EE=1.
{
if (exceptions & EXCEPTION_EXTERNAL_INT)
{
Expand Down

0 comments on commit db96f86

Please sign in to comment.