Android: Don't allow INI editing for DOL/ELF files

dolphin-emu · Jun 6, 2018 · f0f8ca2 · f0f8ca2
1 parent 1c027bc
commit f0f8ca2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameAdapter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameAdapter.java
@@ -139,6 +139,12 @@ public boolean onLongClick(View view)
 		GameViewHolder holder = (GameViewHolder) view.getTag();
 		String gameId = holder.gameFile.getGameId();
 
+		if (gameId.isEmpty())
+		{
+			// We can't make a game-specific INI file if there is no game ID
+			return true;
+		}
+
 		FragmentActivity activity = (FragmentActivity) view.getContext();
 
 		AlertDialog.Builder builder = new AlertDialog.Builder(activity);

diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameRowPresenter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/adapters/GameRowPresenter.java
@@ -87,6 +87,12 @@ public boolean onLongClick(View view)
 				FragmentActivity activity = (FragmentActivity) view.getContext();
 				String gameId = gameFile.getGameId();
 
+				if (gameId.isEmpty())
+				{
+					// We can't make a game-specific INI file if there is no game ID
+					return true;
+				}
+
 				AlertDialog.Builder builder = new AlertDialog.Builder(activity);
 				builder.setTitle("Game Settings")
 					.setItems(R.array.gameSettingsMenus, new DialogInterface.OnClickListener() {