ABI cleanup #1024
ABI cleanup #1024
Conversation
comex
force-pushed
the
abi-cleanup
branch
2 times, most recently
from
a3fcaee
to
fd7a71b
Compare
|
Tested this in Windows with DSP LLE JIT enabled Animal Crossing (GC/non-MMU) - WORKING Code looks good by a cursory glance. Will in-depth review after bugs fixed. |
|
This is the one PR I thought wouldn't have any bugs. |
|
Pasted a couple places where it crashes: http://pastie.org/pastes/9535191/text?key=borsgipzajvp4vab9as5w |
| } | ||
| int size = ((noProlog ? -regSize : 0) - (count * regSize)) & 0xf; | ||
| rsp_alignment -= count * 8; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Ah, there was one missing conversion. fixed. |
|
Code looks good to me. Does @skidau want to make sure those broken games are working now? |
…Stack. - Factor common work into a helper function. - Replace confusingly named "noProlog" with "rsp_alignment". Now that x86 is not supported, we can just specify it explicitly as 8 for clarity. - Add the option to include more frame size, which I'll need later. - Revert a change by magumagu in March which replaced MOVAPD with MOVUPD on account of 32-bit Windows, since it's no longer supported. True, apparently recent processors don't execute the former any faster if the pointer is, in fact, aligned, but there's no point using MOVUPD for something that's guaranteed to be aligned... (I discovered that GenFrsqrte and GenFres were incorrectly passing false to noProlog - they were, in fact, functions without prologs, the original meaning of the parameter - which caused the previous change to break. This is now fixed.)
…k (it didn't preserve FPRs!) and replace with ABI_PushRegistersAndAdjustStack. To avoid FPRs being pushed unnecessarily, I checked the uses: DSPEmitter doesn't use FPRs, and VertexLoader doesn't use anything but RAX, so I specified the register list accordingly. The regular JIT, however, does use FPRs, and as far as I can tell, it was incorrect not to save them in the outer routine. Since the dispatcher loop is only exited when pausing or stopping, this should have no noticeable performance impact.
…_CallFunctionRR. The latter being true was the only case where the former would do anything, and it was never true. They became obsolete with x86's removal.
Improves some code and removes a bunch of unnecessary code.
Someone should test on Windows.