PixelShaderGen: Use LOD bias when sampling texture on Metal and OpenGL ES #10292
Conversation
|
Works as intended (nVidia GeForce GT 750M on macOS 10.15.7). |
| // GL_TEXTURE_LOD_BIAS is not supported on GLES. | ||
| g_Config.backend_info.bSupportsLodBiasInSampler = false; | ||
|
|
There was a problem hiding this comment.
It looks like you're only ever setting it to false for GLES; you're never setting it to true for regular OpenGL. That's probably the cause of the fifoci differences on ogl-lin-mesa.
There was a problem hiding this comment.
I believe I set it to true by default in OGLMain.cpp?
There was a problem hiding this comment.
Ah, yes, I missed that. And FifoCI does seem to be using regular OpenGL (see the build log, which says Dolphin [refs/pull/10292/head] 5.0-15686 | FifoPlayer SC | OpenGL | HLE | FPS: 1 - VPS: 1 - 0% instead of OpenGL ES).
OatmealDome
force-pushed
the
lodbias-take-two
branch
from
bff6db3
to
123f12d
Compare
OatmealDome
force-pushed
the
lodbias-take-two
branch
from
123f12d
to
056613e
Compare
|
someone posted this in forum Version 5.0-15676 fixed the problem of lack of shadows in Rayman 3 in OpenGL ES, but in version 5.0-15706, which is part 2 of this fix in this API, games break when using OpenGL ES and this message appears as this image capture: image https://forums.dolphin-emu.org/attachment.php?aid=19950 https://forums.dolphin-emu.org/Thread-games-crashes-on-opengl-es-from-5-0-15706?pid=523231#pid523231 |
|
#10314 should fix this crash. Sorry about that. |
#9998, take two.
In Twilight Princess, the iris of Midna's eyes disappears as the camera moves further away from her model. This is done by using two mipmaps: one with her iris, and one with just the pale yellow of her sclera. The game sets the distance at which the transition between the two mipmaps occurs by setting the LOD bias value to a large negative value.
To emulate LOD bias in the Vulkan backend,
mipLodBiasin theVkSamplerCreateInfofor the texture's sampler is set. Unfortunately, Metal does not support setting LOD bias in a sampler, somipLodBiasis ignored by MoltenVK. On OpenGL ES, the sampler parameter for setting LOD bias (GL_TEXTURE_LOD_BIAS) is unsupported, unlike desktop OpenGL.This causes Midna's iris to only appear when the camera is very close to her.
While manual texture sampling does solve this issue, it can be less performant at higher resolutions and on low-power platforms (i.e. Android). As a separate workaround, we can pass through a bias value in the
texture()call in the fragment shader, which both OpenGL ES and Metal support.Fixes https://bugs.dolphin-emu.org/issues/11568 and https://bugs.dolphin-emu.org/issues/11993..
Screenshots (macOS)
Broken:
Fixed: