Updater: Embed Updater app within the main app bundle on macOS #10428
Conversation
OatmealDome
force-pushed
the
mac-updater-embed
branch
from
15d7675
to
d8c6e15
Compare
OatmealDome
force-pushed
the
mac-updater-embed
branch
2 times, most recently
from
324da14
to
da7973e
Compare
| "-DMACOS_CODE_SIGNING_IDENTITY_UPDATER=" | ||
| + config["codesign_identity"], | ||
| '-DMACOS_CODE_SIGNING="ON"' | ||
| '-DMACOS_CODE_SIGNING="OFF"' |
There was a problem hiding this comment.
Does code signing not work with the updater in the bundle?
There was a problem hiding this comment.
The final universal bundle is codesigned below, so codesigning the individual bundles is a pointless operation.
We codesign the universal binary at the end, which should be enough.
OatmealDome
force-pushed
the
mac-updater-embed
branch
from
da7973e
to
74a7715
Compare
OatmealDome
force-pushed
the
mac-updater-embed
branch
from
74a7715
to
6a9068e
Compare
|
OK, I tested the updater locally and it was able to update itself to the latest development build fine. I also submitted the latest build of this PR to the notary service and it was accepted. I think this is ready for further review now. |
There was a problem hiding this comment.
The code to move the updater inside the Dolphin.app bundle is in BuildMacOSUniversalBinary.py, which is only run when making a Universal build. Single-architecture builds leave the updater in the old location.
That won't affect users downloading builds from the website, but anyone building from source on an Intel mac will have their updater deleted the next time Dolphin checks for an update. It would also break updating for regular users if/when we start releasing ARM-only builds.
|
Yeah, I put it in there because I couldn't figure out a good way to force CMake to recopy the bundle when |
ghost
mentioned this pull request
This PR embeds
Dolphin Updater.appwithin theDolphin.appbundle. It is inserted into theDolphin.app/Contents/Helpersfolder, which is one of the canonical locations to place helper apps. In addition, if a separateDolphin Updater.appis found during the auto-update cleanup, it is removed.The goal here is to be able to ship a single app bundle to simplify installation. Users may not copy the Updater app from the DMG for whatever reason, preventing Dolphin's auto-update mechanism from working.
The buildbot configuration needs to be updated as well: dolphin-emu/sadm#153. When merging, that PR should be merged right before this PR is merged.