New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UICommon: Add support for portable.txt on macOS #10430
Conversation
85bb9fa
to
bb09b8d
Compare
e934bd8
to
cba32c1
Compare
Would there be a problem if portable.txt and the resulting user folder were inside the bundle? That would allow people to have portable Dolphin in their Applications folder without polluting it. |
I consulted with @ryanmcgrath on this, and this is what he had to say:
Personally, I'm fairly neutral on this. Perhaps both methods can be supported? |
(I tried |
Because the usual method is to drag and drop the .app into the Applications folder it might pollute the App folder with another folder that might look strange and out of place for mac users specially if they use Launchpad a lot, I honestly think is better to leave the default behavior of keeping the user configs and saves in the Application Support folder like most macOS apps do. What it can be done is maybe add an "Open Config Folder.." option into the Dolphin app menu bar so the user gets access to the dolphin folder within the library instantly via Finder and can copy/move/replace files if needed for troubleshooting or backup purposes in a more friendly way. What do you think? |
The point of this PR is not to move the User folder. Instead, I'm introducing an option that already exists on Windows and Linux to force the User folder to be placed next to The User folder will continue to remain in |
Ah okay since its an optional setting I don't see any problem with it, whoever is gonna deal with this already has the knowledge to troubleshoot any situation that can arise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and can confirm that it works as expected on both macOS 12 and Manjaro Linux. Windows wasn't touched by this PR but I've tested that as well.
Code looks good to me too.
This PR adds support for
portable.txt
on macOS. Placing a file namedportable.txt
next toDolphin.app
will force Dolphin to create and use a user directory in the same folder as the app.While this is a very un-Mac like behavior (apps aren't supposed to store files next to the app bundle!), it's useful for development.