New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Override for Boot IOS for Wii Titles #10464
Add Override for Boot IOS for Wii Titles #10464
Conversation
So there's a few thoughts about this. Under our current "settings", this would be enabled by default even for people trying to get an "accurate" console experience. We've been toying with the idea of multiple setting profiles, so a setting like this could be default, but then disabled for an "accuracy" profile or something. As it is, I'm not sure I'm comfortable enabling it by default as it may cause the game to behave differently than expected. Then again, a majority of our users playing Brawl are likely using mods/Project M/Project+, including myself lol. The core idea of being able to override IOSes for Wii games I'm okay with though, as that's something we used to do on console back in the day too. It can affect the loading times of VC games too. I'll summon @leoetlino to review this further, though. |
I'm not opposed to remove the default config for Brawl, but considering we don't have a good place to put this, it would remain fairly hidden to most users. I'm fairly certain there are no adverse affects for loading brawl with IOS 58, I have never seen a gecko code or any patch that everyone says you have to enable with the IOS 58 override that MinimaLauncher applies. |
Yeah, adding the ability to easily override the IOS version (without having to manually edit the TMD) sounds fine. Brawl uses IOS36 by default, so there should be no noticeable timing difference (36 and 58 have the same FS performance characteristics). That being said, I am not entirely comfortable with enabling this by default. We currently don't enable enhancements by default and this is technically making things less accurate for something that isn't even relevant for users unless they are playing with mods. Wouldn't it be better for e.g. Project M to ship this config option in a GameINI as part of the mod? |
Do you have any suggestions on where/how this would be visible to some user trying to load either a modpack (Project M), or just some gecko codes (along with the SDHC code), currently the only place I can think of is on the dolphin wiki page for SSBB, but even then it wouldn't be very obvious/easy... |
Either in the setup instructions for the mod, or using Dolphin's game mod descriptor infrastructure (#10470). Or in a GameINI if the mod distributes Dolphin as part of the release. |
Please squash the commits. |
76562ac
to
652c3f9
Compare
@AdmiralCurtiss done |
Ignore the fifoci, this branch is based on a month-old version. Seems fine to me now, any objections from anyone? |
652c3f9
to
9130ad8
Compare
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
This allows any game to specify a different IOS as the IOS used to boot the game.
The target of this is primarily smash bros, as this allows SDHC cards to be used with the game if Beero's SDHC Gecko Code is used.
Because the target of this is Smash Bro's, the default config for Smash has been updated to override the boot IOS to 58.
I put this under [Core], but I'm not sure that's the best place for this option, if there is a better place tell me, and I'll move it.