Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Android display cutout setting #10548

Closed
wants to merge 2 commits into from

Conversation

simonmarien
Copy link

Issue #12483
Black bar at the top of the display on android.
The app does in fact not support the cutout display.
Make an option in the graphics advanced settings to enable cutout support.

@MayImilae
Copy link
Contributor

Why are you also adding it to Qt?

@mbc07
Copy link
Contributor

mbc07 commented Apr 1, 2022

Isn't the notch a thing now on the newer MacBooks? From that perspective it might be worth adding this to Qt too...

@JosJuice
Copy link
Member

JosJuice commented Apr 1, 2022

Does the implementation in this PR actually work for the MacBook notch, though?

@MayImilae
Copy link
Contributor

MayImilae commented Apr 1, 2022

It is probably not possible to handle the notch on macOS at all. macOS does not want the notch to eat into content, and does not allow it to happen under any circumstances. I'm all for this macOS behavior; I don't mind the notch on my laptop at all because it is handled so well. The menu bar lives up there and that's it.

I do not think this is appropriate option to add to Qt. Display cutouts are not common on desktop OSes (thank goodness) so there's no standardization like what is available on Android. It is highly doubtful that we could take up notch handling across macOS, Windows, and all the Linux DEs. And frankly, I don't think we should.

This should be an Android only feature.

Of course this is all theoretical as this PR kind of does nothing atm but whatever.

@Pokechu22 Pokechu22 marked this pull request as draft April 2, 2022 00:26
@JosJuice
Copy link
Member

JosJuice commented Apr 3, 2022

Closing in favor of PR #10552.

@JosJuice JosJuice closed this Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants