New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Modernize game card #10600
Android: Modernize game card #10600
Conversation
I like it, but I want to see a comparison in light mode as well. |
I get that rounded corners are the current design trend but it's a bit unfortunate that the bottom corners crop out parts of the icons on the box art. That doesn't look great to me. Is the corner radius adjustable at all? |
@PEmu2 The version shown initially in the PR is using 12dp rounding |
While the big rounding of 12dp looks nice, imo not cutting into the Nintendo and rating logos is my preference. So either 8-4dp perhaps? |
It might be best to settle on 4dp if we don't want to cut into the Nintendo and rating logos then Edit - Let me know if that's good to commit |
4dp looks good to me. 8dp still exhibits some of the issues as 12dp. I think I actually like 2dp the best but maybe that rounding is too subtle for other's preferences. |
Sorry for the extra commit, just noticed that the shadow created by the card view was being clipped. Just a one-line fix thankfully. |
4 is good. |
+Remove background on card +Increase max # of lines for game title +Root layout is now a linear layout with the card view rounding the corners on the box art
Squashed and ready |
@t895 So this is only sort of related to this, but would it be possible to add an option to have no text beneath the boxart? The boxart already have the titles on them after all, and it would make for a very, very clean look. Of course care would need to be made to keep it from feeling crowded, but I think it has potential. |
If we add an option for that, I think we should have some kind of fallback to display the title if there is no cover art available. This is needed for homebrew in particular. |
It would be very easy for me to make a "no banner" type image for boxart, and the game's title text could go on top of it so it wouldn't disturb the grid. In theory, anyway. |
@MayImilae I really like the sound of that. I'll look into it if I have the time. |
Remove background on card
Increase max # of lines for game title
Root layout is now a linear layout with the card view rounding the corners on the box art
Depending on
Before -
After -