Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Modernize game card #10600

Merged
merged 1 commit into from Apr 23, 2022
Merged

Android: Modernize game card #10600

merged 1 commit into from Apr 23, 2022

Conversation

t895
Copy link
Contributor

@t895 t895 commented Apr 22, 2022

Remove background on card
Increase max # of lines for game title
Root layout is now a linear layout with the card view rounding the corners on the box art

Depending on

Before -
Before

After -
After

@MayImilae
Copy link
Contributor

I like it, but I want to see a comparison in light mode as well.

@t895
Copy link
Contributor Author

t895 commented Apr 22, 2022

Before Light -
Before

After Light -
After

@PEmu2
Copy link
Contributor

PEmu2 commented Apr 22, 2022

I get that rounded corners are the current design trend but it's a bit unfortunate that the bottom corners crop out parts of the icons on the box art. That doesn't look great to me. Is the corner radius adjustable at all?

@t895
Copy link
Contributor Author

t895 commented Apr 22, 2022

@PEmu2
It is actually adjustable. I would prefer to have some rounded corners than not at all, but here's a few different config options that show the difference if anyone is interested.

The version shown initially in the PR is using 12dp rounding

8dp -
8dp

4dp -
4dp

2dp -
2dp

0dp -
0dp

@MayImilae
Copy link
Contributor

MayImilae commented Apr 22, 2022

While the big rounding of 12dp looks nice, imo not cutting into the Nintendo and rating logos is my preference. So either 8-4dp perhaps?

@t895
Copy link
Contributor Author

t895 commented Apr 22, 2022

It might be best to settle on 4dp if we don't want to cut into the Nintendo and rating logos then

Edit - Let me know if that's good to commit

@PEmu2
Copy link
Contributor

PEmu2 commented Apr 23, 2022

4dp looks good to me. 8dp still exhibits some of the issues as 12dp. I think I actually like 2dp the best but maybe that rounding is too subtle for other's preferences.

@t895
Copy link
Contributor Author

t895 commented Apr 23, 2022

Sorry for the extra commit, just noticed that the shadow created by the card view was being clipped. Just a one-line fix thankfully.

@MayImilae
Copy link
Contributor

4 is good.

+Remove background on card
+Increase max # of lines for game title
+Root layout is now a linear layout with the card view rounding the corners on the box art
@t895
Copy link
Contributor Author

t895 commented Apr 23, 2022

Squashed and ready

@JosJuice JosJuice merged commit 69ca38d into dolphin-emu:master Apr 23, 2022
@MayImilae
Copy link
Contributor

@t895 So this is only sort of related to this, but would it be possible to add an option to have no text beneath the boxart? The boxart already have the titles on them after all, and it would make for a very, very clean look. Of course care would need to be made to keep it from feeling crowded, but I think it has potential.

@JosJuice
Copy link
Member

If we add an option for that, I think we should have some kind of fallback to display the title if there is no cover art available. This is needed for homebrew in particular.

@MayImilae
Copy link
Contributor

It would be very easy for me to make a "no banner" type image for boxart, and the game's title text could go on top of it so it wouldn't disturb the grid. In theory, anyway.

@t895
Copy link
Contributor Author

t895 commented Apr 23, 2022

@MayImilae I really like the sound of that. I'll look into it if I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants