Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt/MemoryWidget: Light refactoring and quality of life features. #10606

Merged
merged 4 commits into from Apr 24, 2022
Merged

Qt/MemoryWidget: Light refactoring and quality of life features. #10606

merged 4 commits into from Apr 24, 2022

Conversation

AdmiralCurtiss
Copy link
Contributor

User-visible changes:

  • Sidebar can now be resized by the user.
  • Right-click menu only shows up when the clicked cell actually has meaningful options for it.
  • Right-click menu now has the option to copy the current value of the cell to clipboard.

Internal changes mostly for readability:

  • Less transient state on the MemoryViewWidget itself.
  • Cells now hold information whether they are the row breakpoint cell or not (instead of that being determined by being in column 0).
  • Cells now hold information whether they are a value cell with a valid value or not (which is used to enable/disable the Copy Hex and Copy Value options).

sepalani
sepalani suggested changes Apr 24, 2022
View reviewed changes
Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp Outdated Show resolved Hide resolved
Source/Core/DolphinQt/Debugger/MemoryViewWidget.cpp Outdated Show resolved Hide resolved
sepalani
sepalani approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@sepalani sepalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Compiled and tested locally on Windows, working as expected.

@AdmiralCurtiss AdmiralCurtiss merged commit 61edcf7 into dolphin-emu:master Apr 24, 2022
@AdmiralCurtiss AdmiralCurtiss deleted the memory-widget-refactoring-1 branch April 24, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepalani sepalani sepalani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@AdmiralCurtiss @sepalani