Android: XLink Kai Android UI option #10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codedwrench
changed the title
codedwrench
force-pushed
the
xlink-kai-android-support
branch
3 times, most recently
from
fa650c7
to
fa7150e
Compare
codedwrench
changed the title
JosJuice
reviewed
May 1, 2022
...roid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/BooleanSetting.java
Outdated
Show resolved
Hide resolved
...d/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityView.java
Outdated
Show resolved
Hide resolved
...ndroid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
Outdated
Show resolved
Hide resolved
...ndroid/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsAdapter.java
Outdated
Show resolved
Hide resolved
...d/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentView.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
May 1, 2022
codedwrench
force-pushed
the
xlink-kai-android-support
branch
from
c713f7f
to
969b4c5
Compare
JosJuice
reviewed
Jul 16, 2022
...ava/org/dolphinemu/dolphinemu/features/settings/ui/viewholder/HeaderHyperLinkViewHolder.java
Outdated
Show resolved
Hide resolved
.../org/dolphinemu/dolphinemu/features/settings/ui/viewholder/InputStringSettingViewHolder.java
Outdated
Show resolved
Hide resolved
.../org/dolphinemu/dolphinemu/features/settings/ui/viewholder/InputStringSettingViewHolder.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/dolphinemu/dolphinemu/features/settings/model/view/InputStringSetting.java
Outdated
Show resolved
Hide resolved
|
Also, could you put the word "Android" in the commit title? (Copying the PR title to the commit title would be fine) |
codedwrench
force-pushed
the
xlink-kai-android-support
branch
from
595d8f6
to
6ac3396
Compare
done |
codedwrench
force-pushed
the
xlink-kai-android-support
branch
from
6ac3396
to
381ad4a
Compare
JosJuice
reviewed
Jul 18, 2022
.../org/dolphinemu/dolphinemu/features/settings/ui/viewholder/InputStringSettingViewHolder.java
Outdated
Show resolved
Hide resolved
codedwrench
force-pushed
the
xlink-kai-android-support
branch
from
381ad4a
to
7e3c0fe
Compare
|
I'm rather confused about what's going on with the buildbots... It doesn't look like it should have anything to do with this PR. |
codedwrench
force-pushed
the
xlink-kai-android-support
branch
2 times, most recently
from
241436f
to
de8457c
Compare
JosJuice
reviewed
Jul 19, 2022
.../src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsActivityPresenter.java
Outdated
Show resolved
Hide resolved
codedwrench
force-pushed
the
xlink-kai-android-support
branch
from
de8457c
to
98c688e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds xlink kai support to the android version of Dolphin, so multiplayer is possible from Android as well.
Below are some screenshots to show what these changes do: